Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel] is displayed when initially closed #10320

Closed
2 of 6 tasks
driskull opened this issue Sep 16, 2024 · 3 comments
Closed
2 of 6 tasks

[Panel] is displayed when initially closed #10320

driskull opened this issue Sep 16, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-09-30 - 2.13...

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

Panel is displayed when closed initially

Expected Behavior

Panel is not displayed

Reproduction Sample

https://codepen.io/driskull/pen/qBzGzmB?editors=1000

Reproduction Steps

  1. open the codepen
  2. notice that panel is shown when it should't be

Reproduction Version

2.12.2

Relevant Info

No response

Regression?

No

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 16, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 16, 2024
@driskull driskull mentioned this issue Sep 16, 2024
Merged
@DitwanP DitwanP added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 16, 2024
@abp6318
Copy link
Contributor

abp6318 commented Sep 16, 2024

Beat me to logging this one. Thank you for writing this up. The ArcGIS Hub team has a temp fix in our repo:

calcite-panel[closed] {
  @apply hidden;
}

@geospatialem geospatialem added has workaround Issues have a workaround available in the meantime. 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 16, 2024
driskull added a commit that referenced this issue Sep 16, 2024
@driskull
fix(panel): initially closed panel should be hidden (#10308)
46de96b 
**Related Issue:** #10320

## Summary

- panel that is initially closed should not be displayed
- add story
- add test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 16, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Sep 18, 2024

🍠 Verified on 2.13.0-next.15

@DitwanP DitwanP closed this as completed Sep 18, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @DitwanP @abp6318