-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Migrate Sass to be 2.0.0-friendly #33
Comments
I noticed that these are handled in the @paulcpederson @macandcheese Could we possibly publish to NPM as |
@jcfranco are these the only changes required? https://github.com/Esri/calcite-base/pull/34/files |
@paulcpederson I think these should be it: 8279f24~...3ced2eb |
Oh, right I remember this. I think we could just merge these into master and publish them as 2.0.0. |
Description
The latest dependency bump led to the following build warnings:
We should migrate our style files to be Sass 2.0.0 ready. The following are some changes that will be needed:
math.div
instead of/
@use
(and@forward
) instead of@import
Proposed Advantages
Prevent moving to the latest dependencies when they move to Sass 2.0.0.
Relevant Info
Sass provides a migrating tool to help with this: https://sass-lang.com/documentation/cli/migrator
Dependencies that use Sass will likely also need to be updated (e.g.,
calcite-base
).The text was updated successfully, but these errors were encountered: