removed text node from fitler label.

[pr3tori4n]

Related Issue: #333

Summary

[jcfranco]

👍

[driskull]

There still needs to be a prop textFilterLabel for a user to be able to set this text. Otherwise, its still a hard coded value.

[pr3tori4n]

@driskull There is a prop textLabel

calcite-app-components/src/components/calcite-filter/calcite-filter.tsx

Line 30 in d7536f6

@Prop() textLabel: string;

[driskull]

@pr3tori4n ok

fixme: should we update the doc description? It no longer appears there right?

/**
   * A text label that will appear next to the input field.
   */

nitpick: Could the text filter just be set by default and not have the fallback in render? This gives the user the ability to get rid of it if they really want to.

  @Prop() textLabel = Text.filterLabel;

[pr3tori4n]

nitpick: Could the text filter just be set by default and not have the fallback in render? This gives the user the ability to get rid of it if they really want to.

On second thought no, there needs to be something there or else this component will fail a11y.

Updated the comment.

[driskull]

Good once comment updated on doc.