Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix(lists): added bg-color rules. #365

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

asangma
Copy link
Contributor

@asangma asangma commented Oct 9, 2019

Related Issue: #364

Summary

Added bg-color rules for lists.

@asangma asangma added this to the Choose Goose milestone Oct 9, 2019
@asangma asangma requested review from driskull and pr3tori4n October 9, 2019 22:09
@asangma asangma requested a review from a team as a code owner October 9, 2019 22:09
@asangma asangma self-assigned this Oct 9, 2019
@asangma
Copy link
Contributor Author

asangma commented Oct 9, 2019

before
image

after
image

@asangma
Copy link
Contributor Author

asangma commented Oct 9, 2019

For both pick-list and value-list, this allows the parent node to decide whether to show the item shape or not by matching the bg-color or using the light gray bg-color.

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asangma asangma merged commit c6228a0 into master Oct 9, 2019
@asangma asangma deleted the asangma/bg-color-fix-post-364 branch October 9, 2019 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants