Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: When using tooltips with an action, browsers title popup shows up #871

Closed
kevindoshier opened this issue Mar 3, 2020 · 2 comments
Closed

Enhancement: When using tooltips with an action, browsers title popup shows up #871

kevindoshier opened this issue Mar 3, 2020 · 2 comments
Assignees
@kevindoshier
Labels
4 - verified enhancement New feature request for an existing component
Milestone
Ice King

Comments

@kevindoshier
Copy link

kevindoshier commented Mar 3, 2020 •
edited
Loading

Description

When using tooltips bound to an action, we dont want to see the default browser title show up, to do that now I set the "label" property of an action to an empty string but then in some browsers we still see the browsers title popup appear empty, would be good if there was a way to signal the action to not add a "title" to the element

cc: @driskull

https://github.com/Esri/calcite-app-components/blob/master/src/components/calcite-action/calcite-action.tsx#L157

Acceptance Criteria

Relevant Info

Which Component

Example Use Case
@kevindoshier kevindoshier added 0 - new enhancement New feature request for an existing component labels Mar 3, 2020
@driskull driskull self-assigned this Mar 3, 2020
@driskull driskull added this to the Ice King milestone Mar 3, 2020
driskull added a commit that referenced this issue Mar 3, 2020
@driskull
#871 don't automatically set title on the button. Let the user set th…
91bec09 
…e title on the action if they want it. This is to allow them to create tooltips.
@driskull driskull mentioned this issue Mar 3, 2020
Merged
driskull added a commit that referenced this issue Mar 3, 2020
@driskull
fix(action): When using tooltips with an action, browsers title popup…
0c1fa41 
… shows up (#872)

* #871 don't automatically set title on the button. Let the user set the title on the action if they want it. This is to allow them to create tooltips.

* fix test
@driskull driskull assigned kevindoshier and unassigned driskull Mar 3, 2020
@kat10140
Copy link
Contributor

@kevindoshier

@kevindoshier
Copy link
Author

Looks good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevindoshier kevindoshier

Labels
4 - verified enhancement New feature request for an existing component
Projects
None yet
Milestone
Ice King
Development

No branches or pull requests
3 participants
@driskull @kevindoshier @kat10140