Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: Nested list items in pick list #767

Closed
pr3tori4n opened this issue Jan 16, 2020 · 6 comments
Closed

Enhancement: Nested list items in pick list #767

pr3tori4n opened this issue Jan 16, 2020 · 6 comments
Assignees
@pr3tori4n
Labels
3 - installed enhancement New feature request for an existing component
Milestone
Hot Dog Princess

Comments

@pr3tori4n
Copy link
Contributor

Description

  • A Pick List's items can be nested to create a heirarchy.
  • The parent items should be selectable.
  • The filter should show children when it matches a parent element.
  • The filter should show a parent ( but not siblings ) when matching a child element.
@pr3tori4n pr3tori4n added enhancement New feature request for an existing component 0 - new labels Jan 16, 2020
@pr3tori4n pr3tori4n self-assigned this Jan 16, 2020
@pr3tori4n pr3tori4n mentioned this issue Jan 16, 2020
Merged
asangma added a commit that referenced this issue Jan 24, 2020
@asangma
Some clean up and demo updates (#767)
c4e6814
asangma added a commit that referenced this issue Jan 24, 2020
@asangma
Better check and radio UI. Interim solution until Icon Team delivers …
696b062 
…a `blank` icon. (#767)
asangma added a commit that referenced this issue Jan 24, 2020
@asangma
Only render secondary action node if slot is populated. (#767)
fb9ff75
asangma added a commit that referenced this issue Jan 24, 2020
@asangma
Added indented modifier class. Spacing and demo updates. (#767)
743fbc8
asangma added a commit that referenced this issue Jan 24, 2020
@asangma
RTL for list group (#767)
ab895aa
@asangma asangma mentioned this issue Jan 24, 2020
Merged
asangma added a commit that referenced this issue Jan 24, 2020
@asangma
Nixed unnecessary classnames. (#767)
c87893f
@driskull driskull added this to the Hot Dog Princess milestone Jan 28, 2020
asangma added a commit that referenced this issue Jan 30, 2020
@asangma
feat: add styling and some updates for pick-list nesting (#783)
3c0324d 
* initial tweaks

* Some clean up and demo updates (#767)

* Better check and radio UI. Interim solution until Icon Team delivers a `blank` icon. (#767)

* Only render secondary action node if slot is populated. (#767)

* Added `indented` modifier class. Spacing and demo updates. (#767)

* RTL for list group (#767)

* style update using template literal.

* reset demo page.

* reset demo pages.

* Nixed unnecessary classnames. (#767)

* Removed unnecessary `container` style. Added default class for container section node. Updated demos to also show non-nested pick-list-group.
pr3tori4n added a commit that referenced this issue Jan 30, 2020
@pr3tori4n @asangma
feat: Add nesting support to picklist groups (#770)
602264b 
* Add nesting support to groups

* rename slot

* adding tests

* code review comment follow up

* feat: add styling and some updates for pick-list nesting (#783)

* initial tweaks

* Some clean up and demo updates (#767)

* Better check and radio UI. Interim solution until Icon Team delivers a `blank` icon. (#767)

* Only render secondary action node if slot is populated. (#767)

* Added `indented` modifier class. Spacing and demo updates. (#767)

* RTL for list group (#767)

* style update using template literal.

* reset demo page.

* reset demo pages.

* Nixed unnecessary classnames. (#767)

* Removed unnecessary `container` style. Added default class for container section node. Updated demos to also show non-nested pick-list-group.

* fix test

Co-authored-by: Alan Sangma <asangma@esri.com>
@pr3tori4n pr3tori4n assigned kat10140 and unassigned pr3tori4n Jan 30, 2020
@pr3tori4n
Copy link
Contributor Author

@kat10140 please verify.

@kat10140
Copy link
Contributor

kat10140 commented Feb 6, 2020

@pr3tori4n if a parent is selected, are the children meant to be selected as well? looks like they're all single select right now

@kat10140
Copy link
Contributor

kat10140 commented Feb 6, 2020

Screen Shot 2020-02-06 at 3 20 27 PM
it looks like the filter is showing siblings in this case

@kat10140 kat10140 assigned pr3tori4n and unassigned kat10140 Feb 19, 2020
@pr3tori4n
Copy link
Contributor Author

@kat10140 I don't believe this was requested. It was requested the parents be selectable, but not that selecting a parent auto-selects the children. If that's desired, I'd suggest we open a new enhancement issue to cover that behavior.

@kat10140
Copy link
Contributor

kat10140 commented Feb 21, 2020 •
edited
Loading

  • The filter should show a parent ( but not siblings ) when matching a child element.

Oh, thats how i interpreted the last bullet of the issue. If that's not the case, we can close this one @pr3tori4n

@pr3tori4n
Copy link
Contributor Author

@kat10140 no worries. I believe that's meant to describe the hide/show behavior not the selection behavior. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pr3tori4n pr3tori4n

Labels
3 - installed enhancement New feature request for an existing component
Projects
None yet
Milestone
Hot Dog Princess
Development

No branches or pull requests
3 participants
@driskull @pr3tori4n @kat10140