Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: calcite-action - add scale option #759

Closed
AdelheidF opened this issue Jan 15, 2020 · 6 comments
Closed

Enhancement: calcite-action - add scale option #759

AdelheidF opened this issue Jan 15, 2020 · 6 comments
Assignees
@kat10140
Labels
4 - verified enhancement New feature request for an existing component
Milestone
Hot Dog Princess

Comments

@AdelheidF
Copy link

AdelheidF commented Jan 15, 2020 •
edited
Loading

Description

Currently the calcite-action is using up a lot of width/height when used inside a 'text box'. It would be nice if there was an option to have a small size.

image

From the labeling config design:
image

And could we use a small version then in pick-list so there's less blank space?, maybe compact=true works there too.

cc @asangma

Acceptance Criteria

Relevant Info

Which Component

Example Use Case
@AdelheidF AdelheidF added 0 - new enhancement New feature request for an existing component labels Jan 15, 2020
@driskull
Copy link
Member

@asangma what do you think? If we add scale, would we get rid of compact?

@driskull driskull assigned asangma and unassigned driskull and pr3tori4n Jan 22, 2020
@driskull driskull added this to the Hot Dog Princess milestone Jan 28, 2020
@asangma
Copy link
Contributor

asangma commented Jan 29, 2020

@driskull Yeah...better to follow our other patterns and use CalciteScale.

asangma added a commit that referenced this issue Jan 29, 2020
@asangma
enhancement to add scales to Action. (#759)
b46c031
asangma added a commit that referenced this issue Jan 29, 2020
@asangma
Made default scale style explicit. (#759)
5037e87
@asangma asangma mentioned this issue Jan 29, 2020
Merged
asangma added a commit that referenced this issue Jan 29, 2020
@asangma
Added demos and styles for indicator and RTL indicator. (#759)
3ea8f7a
asangma added a commit that referenced this issue Jan 29, 2020
@asangma
Added scale knob to storybook. Added scale prop to readme. (#759)
a29a9d9
asangma added a commit that referenced this issue Jan 29, 2020
@asangma
Removed compact knob from Action storybook. (#759)
38129dc
@asangma asangma mentioned this issue Jan 29, 2020
Closed
asangma added a commit that referenced this issue Jan 29, 2020
@asangma
feat(action): add scales to Action
c5948cb 
* enhancement to add scales to Action. (#759)

* Made default scale style explicit. (#759)

* Added demos and styles for indicator and RTL indicator. (#759)

* Added scale knob to storybook. Added scale prop to readme. (#759)

* Removed compact knob from Action storybook. (#759)
@asangma asangma mentioned this issue Jan 30, 2020
Merged
asangma added a commit that referenced this issue Jan 30, 2020
@asangma
fix(action): style updates for compact mode
bc345ce 
#759
@asangma
Copy link
Contributor

asangma commented Jan 30, 2020 •
edited
Loading

@AdelheidF this is installed but not yet released yet. Feel free to start adding the scale prop to any actions you deem in need of small-ness.

@asangma asangma assigned kat10140 and unassigned asangma Feb 4, 2020
@asangma
Copy link
Contributor

asangma commented Feb 4, 2020

@kat10140 Make for the verfee?

@kat10140
Copy link
Contributor

kat10140 commented Feb 4, 2020

verified!

@kat10140 kat10140 closed this as completed Feb 4, 2020
@AdelheidF
Copy link
Author

Looks good

image

Will add it for map viewer beta 4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified enhancement New feature request for an existing component
Projects
None yet
Milestone
Hot Dog Princess
Development

No branches or pull requests
5 participants
@driskull @asangma @pr3tori4n @AdelheidF @kat10140