Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: [Block] unintentional toggle when control is focused and Space/Enter is pressed #751

Closed
jcfranco opened this issue Jan 10, 2020 · 6 comments
Closed

Bug: [Block] unintentional toggle when control is focused and Space/Enter is pressed #751

jcfranco opened this issue Jan 10, 2020 · 6 comments
Assignees
@kat10140
Labels
4 - verified bug Something isn't working
Milestone
Grob Gob Glob Grod

Comments

@jcfranco
Copy link
Member

Summary

Bubbled keyboard events (Space/Enter) can cause the block to unintentionally toggle.

Actual Behavior

Block is toggled when a Space/Enter keyboard event is dispatched from a control element.

Expected Behavior

!:point_up:

Reproduction Steps

  1. Open the following test case.
  2. Focus on the control
  3. Press Space or Enter key
  4. Note how the block is toggled (unexpected)
@jcfranco jcfranco added bug Something isn't working 0 - new labels Jan 10, 2020
@jcfranco jcfranco self-assigned this Jan 10, 2020
@jcfranco jcfranco added this to the Grob Gob Glob Grod milestone Jan 10, 2020
jcfranco added a commit that referenced this issue Jan 11, 2020
@jcfranco
Issue #751: Prevent unintentional toggling from bubbled control space…
5eacd6f 
…/enter.
@jcfranco jcfranco mentioned this issue Jan 11, 2020
Closed
jcfranco added a commit that referenced this issue Jan 15, 2020
@jcfranco
fix(block): prevent unintentional toggling when interacting with a sl…
6a2a594 
…otted control

#751
@jcfranco jcfranco mentioned this issue Jan 15, 2020
Merged
jcfranco added a commit that referenced this issue Jan 16, 2020
@jcfranco
fix(block): prevent unintentional toggling when interacting with a sl…
217203a 
…otted control (#762)

#751
@jcfranco
Copy link
Member Author

Installed.

@jcfranco jcfranco assigned kat10140 and unassigned jcfranco Jan 16, 2020
@kat10140
Copy link
Contributor

@jcfranco looks like it's still happening with the test case you provided. should i test this somewhere else?

@jcfranco
Copy link
Member Author

@kat10140 This fix will be in the next release, so you'll need to test locally for now.

@kat10140
Copy link
Contributor

@jcfranco this is happening locally and on the test case you provided.

@jcfranco
Copy link
Member Author

It works fine using the latest: https://codepen.io/jcfranco-the-scripter/pen/VwYOBPz

  1. Focus on the control text (focus me and hit SPACE/ENTER)
  2. Press Space or Enter key
  3. Block is not toggled. ✅

@kat10140
Copy link
Contributor

facepalm. i only changed the version of the stylesheets

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified bug Something isn't working
Projects
None yet
Milestone
Grob Gob Glob Grod
Development

No branches or pull requests
2 participants
@jcfranco @kat10140