This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
fix!: Flow - Remove current panel automatically when back is clicked #586 #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back is clicked #586. Remove deprecations. Remove text-display in favor of textEnabled
driskull
added
enhancement
|
@jcfranco @pr3tori4n This is the breaking changes PR that changes the way the flow It also removes all the other deprecated events, properties, methods. @asangma I also removed the |
|
@asangma When would we want to install this? We can do it after the next MapViewer release. When is that? |
…back-rework-remove-deprecations # Conflicts: # src/components/calcite-action/calcite-action.tsx
# Conflicts: # src/components/calcite-action/calcite-action.tsx # src/components/calcite-pick-list/calcite-pick-list.tsx
asangma
reviewed
Dec 16, 2019
jcfranco
reviewed
Dec 17, 2019
|
|
||
| const flow = await page.find("calcite-flow"); | ||
|
|
||
| await flow.callMethod("back"); |
There was a problem hiding this comment.
Based on the updates, this should also assert that an item got returned.
There was a problem hiding this comment.
Having trouble getting the item returned. Is it ok with just checking something is defined? The tests don't seem to work with the E2E element returning.
asangma
approved these changes
Dec 17, 2019
# Conflicts: # src/components/calcite-action/calcite-action.tsx
pr3tori4n
suggested changes
Dec 19, 2019
pr3tori4n
approved these changes
Dec 19, 2019
driskull
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Flow - Remove current panel automatically when back is clicked
Related Issue: #586
Summary