Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: Flow should remove the current panel automatically when back is clicked #586

Closed
driskull opened this issue Nov 22, 2019 · 2 comments
Assignees
Labels
4 - verified blocked Waiting on a dependency enhancement New feature request for an existing component p - medium refactor

Comments

@driskull
Copy link
Member

Description

Enhancement: Flow should remove the current panel automatically when back is clicked

From: https://github.com/Esri/calcite-app-components/wiki/2019-Weekly-Meeting#2019-11-15

Acceptance Criteria

Add property beforeBack.

@Prop() beforeBack: () => Promise<void> = () =>

Which Component

CalciteFlow

@driskull driskull added enhancement New feature request for an existing component 1 - assigned p - medium refactor blocked Waiting on a dependency labels Nov 22, 2019
@driskull driskull added this to the Eberhardt milestone Nov 22, 2019
@driskull driskull self-assigned this Nov 22, 2019
@driskull
Copy link
Member Author

This will be a breaking change, so I will remove all deprecations as well.

@pr3tori4n pr3tori4n modified the milestones: Eberhardt, Fern Dec 4, 2019
driskull added a commit that referenced this issue Dec 6, 2019
…back is clicked #586. Remove deprecations. Remove text-display in favor of textEnabled
@kat10140 kat10140 modified the milestones: Fern, Grob Gob Glob Grod Dec 6, 2019
driskull added a commit that referenced this issue Dec 19, 2019
…586 (#608)

* Enhancement: Flow should remove the current panel automatically when back is clicked #586. Remove deprecations. Remove text-display in favor of textEnabled

* fix tests

* reverse deprecation for breaking change after fern.

* fix typing

* small fixes

* review fixes; test in progress.

* cleanup

* demos update, make beforeBack optional.

* fix test

* fix tests

* fix test

* no message

* need to get this test working

* put animation back.

* update tests for action

* get things running

* test code

* simplify test

* called 1 time

* review fixes

* promise review update

* review fixes
@driskull driskull assigned pr3tori4n and unassigned driskull Dec 19, 2019
driskull added a commit that referenced this issue Jan 3, 2020
* Enhancement: Flow should remove the current panel automatically when back is clicked #586. Remove deprecations. Remove text-display in favor of textEnabled

* fix tests

* reverse deprecation for breaking change after fern.

* fix typing

* small fixes

* review fixes; test in progress.

* cleanup

* demos update, make beforeBack optional.

* fix test

* fix tests

* fix test

* no message

* need to get this test working

* put animation back.

* update tests for action

* get things running

* test code

* simplify test

* called 1 time

* review fixes

* refactor: action - remove label
Use text string for title and aria-label when text is disabled

* change logic for label and text

* text container should always be in dom.

* fix test, fix label optional, fix textEnabled reflecting

* fix demo labels

* fix action tests

* title fix

Co-authored-by: Matt Driscoll <driskull@users.noreply.github.com>
@driskull driskull assigned jcfranco and unassigned pr3tori4n Jan 3, 2020
@jcfranco
Copy link
Member

Verified locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified blocked Waiting on a dependency enhancement New feature request for an existing component p - medium refactor
Projects
None yet
Development

No branches or pull requests

4 participants