This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
test(block-section): add a11y tests #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR submitted: Esri/calcite-design-system#259 |
|
☝️ merged! This now depends on us bumping |
BREAKING CHANGE: @esri/calcite-components@1.0.0-beta.14 introduced breaking changes (see https://github.com/Esri/calcite-components/blob/c365346de6866fc46e468985dd19d6beb4624483/CHANGELOG.md#v100-beta14---nov-18th-2019 for more info).
driskull
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #552
Summary
Adds missing a11y tests to
calcite-block-section.Also, enhances common test helpers with page setup options and improves the testing utility to use the vendor components instead of the hardcoded
unpkg.comURL.Note: there's a failing test because of an invalid attribute being added bycalcite-switch. I'll submit a PR and this for review as soon as it's installed.BREAKING CHANGE: bumps
@esri/calcite-componentsto version v1.0.0-beta.16 (beta.14 introduced breaking changes).