This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
fix: calcite-block disabled state doesn't 'hide' slider handle #560 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcfranco if this approach sounds good, I can update all the other files that use |
|
This changes the design slightly by hiding all the content. cc @asangma Does the shuffling of the slot impact the block's size? |
What do you mean?
It shouldn't. the div only has positioning of relative and z-index. |
|
Brain fart, never mind. I like this. |
driskull
commented
Nov 15, 2019
driskull
commented
Nov 15, 2019
| }; | ||
|
|
||
| export const CalciteScrim: FunctionalComponent<ScrimProps> = ({ loading, disabled }, children) => | ||
| disabled || loading |
There was a problem hiding this comment.
moved this into the functional component because it was repetitive throughout the other components. It won't return anything if its not disabled or loading.
jcfranco
approved these changes
Nov 15, 2019
| @@ -215,7 +209,7 @@ export class CalcitePanel { | |||
| {this.renderContent()} | |||
| {this.renderFooter()} | |||
| </article> | |||
| {this.renderScrim()} | |||
| <CalciteScrim loading={loading} disabled={disabled}></CalciteScrim> | |||
There was a problem hiding this comment.
Can you self-close childless tags?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #560
fix: calcite-block disabled state doesn't 'hide' slider handle #560