Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: calcite-block disabled state doesn't 'hide' slider handle #560

Closed
AdelheidF opened this issue Nov 14, 2019 · 5 comments
Closed

Bug: calcite-block disabled state doesn't 'hide' slider handle #560

AdelheidF opened this issue Nov 14, 2019 · 5 comments
Assignees
Labels
4 - verified bug Something isn't working p - medium

Comments

@AdelheidF
Copy link

Summary

image

cc @asangma @jcfranco

Actual Behavior

Expected Behavior

Reproduction Steps

Relevant Info

@AdelheidF AdelheidF added 0 - new bug Something isn't working labels Nov 14, 2019
@jcfranco jcfranco added this to the Eberhardt milestone Nov 14, 2019
@jcfranco jcfranco self-assigned this Nov 14, 2019
@jcfranco
Copy link
Member

The scrim currently uses a z-index of 2, so there are cases where siblings in the same stacking context will show above it. I propose for now a simple CSS var for the scrim's z-index and if necessary, we can create a follow-up issue for something more involved to guarantee that it's always above.

@asangma @pr3tori4n @driskull WDYT?

@driskull
Copy link
Member

@jcfranco This is the current structure of the scrim

<div class={CSS.content} hidden={!hasContent || !open}>
   <slot />
  {loading || disabled ? <CalciteScrim loading={false}></CalciteScrim> : null}
</div>

Can we just do the following to get the stacking index relative to where the scrim is?

<div class={CSS.content} hidden={!hasContent || !open}>
  <div style="position:relative; z-index:1">
     <slot />
  </div>
  <div>
  {loading || disabled ? <CalciteScrim loading={false}></CalciteScrim> : null}
</div>

@driskull
Copy link
Member

We could also enhance <CalciteScrim> to surround the content you want contained in the right z-index stacking. That might be even better.

@jcfranco jcfranco assigned driskull and unassigned jcfranco Nov 15, 2019
driskull added a commit that referenced this issue Nov 15, 2019
…567)

* handle zIndex issues for CalciteScrim

* scrim for panel

* apply to other components.

* cleanup

* revert stuff

* set loading prop

* more legible code

* self closing tags
@driskull driskull assigned AdelheidF and unassigned driskull Nov 15, 2019
@jcfranco
Copy link
Member

@AdelheidF Can you help verify this one?

@AdelheidF
Copy link
Author

Tested locally. Seems fine now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified bug Something isn't working p - medium
Projects
None yet
Development

No branches or pull requests

3 participants