Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: Tip. Header still renders when non-dismissible and no heading slot content #566

Closed
asangma opened this issue Nov 15, 2019 · 3 comments
Closed

Bug: Tip. Header still renders when non-dismissible and no heading slot content #566

asangma opened this issue Nov 15, 2019 · 3 comments
Assignees
@asangma
Labels
3 - installed bug Something isn't working p - medium
Milestone
Fern

Comments

@asangma
Copy link
Contributor

asangma commented Nov 15, 2019

Summary

Actual Behavior

image

Expected Behavior

image

Reproduction Steps

  1. Make a Tip with no heading and non-dismissible

Relevant Info

@asangma asangma added bug Something isn't working 0 - new labels Nov 15, 2019
@asangma asangma self-assigned this Nov 15, 2019
@asangma
Copy link
Contributor Author

asangma commented Nov 15, 2019

note: there are probz a few other CSS things to go along with this.

@kat10140 kat10140 added this to the Fern milestone Dec 4, 2019
@kat10140 kat10140 assigned driskull and unassigned asangma Dec 6, 2019
driskull added a commit that referenced this issue Dec 6, 2019
@driskull
Only render header when a heading exists or the dismiss button. #566
4fcade8
@driskull driskull mentioned this issue Dec 6, 2019
Merged
driskull added a commit that referenced this issue Dec 9, 2019
@driskull
fix: Only render header when a heading exists or the dismiss button. #…
3aaadec 
…566 (#613)

* Only render header when a heading exists or the dismiss button. #566

* review fixes

* update declaration path
@driskull driskull assigned asangma and unassigned driskull Dec 9, 2019
@driskull
Copy link
Member

driskull commented Dec 9, 2019

Installed

@asangma
Copy link
Contributor Author

asangma commented Dec 11, 2019

VERFEED!

@asangma asangma closed this as completed Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@asangma asangma

Labels
3 - installed bug Something isn't working p - medium
Projects
None yet
Milestone
Fern
Development

No branches or pull requests
4 participants
@jcfranco @driskull @asangma @kat10140