Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: panel. Don't render header leading or trailing nodes when empty #547

Closed
asangma opened this issue Nov 12, 2019 · 4 comments
Closed

Bug: panel. Don't render header leading or trailing nodes when empty #547

asangma opened this issue Nov 12, 2019 · 4 comments
Assignees
@kat10140
Labels
4 - verified bug Something isn't working p - medium

Comments

@asangma
Copy link
Contributor

asangma commented Nov 12, 2019

Summary

re: header. Only render related notes when content is passed to leading and trailing slots in header.

Actual Behavior

When leading slot is empty, flex justify-content still acts like there's stuff in there.
image

Expected Behavior

image

Reproduction Steps

Relevant Info

@asangma asangma added bug Something isn't working 0 - new labels Nov 12, 2019
@asangma asangma self-assigned this Nov 12, 2019
@asangma asangma added this to the Eberhardt milestone Nov 12, 2019
@driskull
Copy link
Member

@asangma if we remove the nodes when the slot is not populated the close button would be to the left. How would we address that?

@asangma
Copy link
Contributor Author

asangma commented Nov 13, 2019

The header is justify-content: space-between. It should automatically layout like the above screen if there's no leading slot. I will have to check what it looks like when there's not trailing. Either way, it looks weird currently.

asangma added a commit that referenced this issue Nov 14, 2019
@asangma
Fix for panel header leading slot causing weird layout. (#547)
e1586e4
asangma added a commit that referenced this issue Nov 14, 2019
@asangma
Fix for panel header layout. Tweaks. (#547)
992b9fa
@asangma asangma mentioned this issue Nov 14, 2019
Merged
asangma added a commit that referenced this issue Nov 14, 2019
@asangma
UI tweak because @mitc7862 said so. Adds a little more padding to hea…
0216a17 
…der-content (#547)
asangma added a commit that referenced this issue Nov 14, 2019
@asangma
fix(panel): header-content layout when leading slot is empty (#547)
2bff76a 
* Fix for panel header leading slot causing weird layout. (#547)

* Fix for panel header layout. Tweaks. (#547)

* UI tweak because @mitc7862 said so. Adds a little more padding to header-content (#547)

* re: last commit. Forgot RTL.

* small tweak for (#556)
@asangma asangma assigned kat10140 and unassigned asangma Nov 14, 2019
@asangma
Copy link
Contributor Author

asangma commented Nov 14, 2019

@kat10140 Please verfee. :)

@kat10140
Copy link
Contributor

kat10140 commented Dec 4, 2019

verified!

@kat10140 kat10140 closed this as completed Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified bug Something isn't working p - medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driskull @asangma @kat10140