Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: (pick-list-item) disable summary in compact mode #447

Closed
asangma opened this issue Oct 23, 2019 · 3 comments
Closed

Enhancement: (pick-list-item) disable summary in compact mode #447

asangma opened this issue Oct 23, 2019 · 3 comments
Assignees
@kat10140
Labels
4 - verified enhancement New feature request for an existing component
Milestone
Donny

Comments

@asangma
Copy link
Contributor

asangma commented Oct 23, 2019 •
edited
Loading

Description

Disable the summary (textDescription) when compact is true.

Acceptance Criteria

Summary doesn't show when compact.

Desired New Behavior

Summary doesn't show when compact.

Desired Change to Look and Feel

Tighter vertical spacing.
Might could also reduce padding.

Relevant Info

#390

Helpful Details

Which Component: pick-list-item
@asangma asangma added enhancement New feature request for an existing component 1 - assigned labels Oct 23, 2019
@asangma asangma added this to the Eberhardt milestone Oct 23, 2019
@asangma asangma self-assigned this Oct 23, 2019
asangma added a commit that referenced this issue Oct 23, 2019
@asangma
style(pick-list-item): disable text-description when compact. initial…
3b51797 
… associated styles. (#447 #390)
@asangma asangma modified the milestones: Eberhardt, Donny Oct 25, 2019
asangma added a commit that referenced this issue Oct 25, 2019
@asangma
exclude text-description when in compact mode. Added some margin to a…
114dc79 
…ction to retain a min height. (#447)
@asangma asangma mentioned this issue Oct 25, 2019
Merged
@asangma asangma assigned kat10140 and unassigned asangma Oct 29, 2019
@asangma
Copy link
Contributor Author

asangma commented Oct 29, 2019

MURGLED! @kat10140 Please verfee.

@kat10140
Copy link
Contributor

Verifeeeeed

@asangma
Copy link
Contributor Author

asangma commented Oct 29, 2019

💥

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified enhancement New feature request for an existing component
Projects
None yet
Milestone
Donny
Development

No branches or pull requests
2 participants
@asangma @kat10140