Bug: calcite-pick-list filter is hiding all items #400

AdelheidF · 2019-10-17T23:14:06Z

Summary

Using "@esri/calcite-app-components@4.2.1"

(1)

When using the filter the list goes empty and doesn't come back when I remove the filter.

(2)

When using slot menu-actions with a dropdown there's a CSS issue.
Separate issue created: Bug: pick-list action slot styling #417

        <calcite-pick-list
          filter-enabled="true"
          multiple="true"
        >
          <calcite-dropdown slot="menu-actions" alignment="right">
            <calcite-action
              slot="dropdown-trigger"
              onclick=...
              label="Sort"
            >
              <svg>...</svg>
            </calcite-action>
            <calcite-dropdown-group grouptitle="Sort by">
              <calcite-dropdown-item active>Display name</calcite-dropdown-item>
              <calcite-dropdown-item>Type</calcite-dropdown-item>
            </calcite-dropdown-group>
          </calcite-dropdown>
          {items}
        </calcite-pick-list>

(3)

When in multiple=false mode I can deselect the single selected radio button by clicking on it again. I don't think it should let me do that. When in radio button mode there should be always one selected.

When using the "calciteListChange" event on a filtered list I assume I still get all checked items, correct? The filter doesn't affect the list of items. Can't test this currently.

Actual Behavior

Expected Behavior

Reproduction Steps

local version of https://devext.arcgis.com/apps/mapviewer/index.html

Relevant Info

The text was updated successfully, but these errors were encountered:

jbartley · 2019-10-22T17:42:25Z

What is the latest on this issue? @pr3tori4n

pr3tori4n · 2019-10-22T18:02:39Z

@jbartley I'm trying to find the root cause. I'm having trouble reproducing this in isolation. I just found out that Adelheide has a test-app setup in the app-components repo so I'm going to take a look at that. This is a priority for me.

pr3tori4n · 2019-10-22T18:06:25Z

When using the "calciteListChange" event on a filtered list I assume I still get all checked items, correct? The filter doesn't affect the list of items. Can't test this currently.

@AdelheidF That's correct. The filter only changes what's displayed, it doesn't affect the current selections.

pr3tori4n · 2019-10-22T18:10:01Z

When in multiple=false mode I can deselect the single selected radio button by clicking on it again. I don't think it should let me do that. When in radio button mode there should be always one selected.

@kat10140 @asangma Can you triage this and create an enhancement issue. Do we need a flag for this behavior (there a use case for the way we have it now?) or can we just modify the default?

pr3tori4n · 2019-10-22T23:20:10Z

@AdelheidF @jbartley @jcfranco this is being caused by the same Maquette.js issue we saw when the pre-selection wasn't working. I hesitate to move more setup code to run after first-render. I'd like to dig into Maquette a bit and see why this is happening - why some attributes are populated on first render, but others aren't. This could happen with other components as well so I'd like to do more research. If there's a way of preventing this behavior in using Maquette that'd be the ideal solution imo. If not, we might find a better solution with some more advanced mutationObservers.

@AdelheidF if you need a workaround soon - I can offer you something temporary in the meantime. Let me know.

AdelheidF · 2019-10-22T23:27:59Z

if you need a workaround soon - I can offer you something temporary in the meantime. Let me know.

Since it's already on devext and pretty obvious a temporary solution would be great. Thanks!

jcfranco · 2019-10-23T01:21:56Z

why some attributes are populated on first render, but others aren't.

I doubt this is being caused by maquette. Could it be some NonReact™ component oddness?

pr3tori4n · 2019-10-23T22:39:29Z

@AdelheidF @jbartley I have a temporary fix in until I find out the true root cause.

pr3tori4n · 2019-10-24T19:42:47Z

@kat10140 can you help triage this item and move #3 into a separate issue?

kat10140 · 2019-10-29T23:44:22Z

~~@pr3tori4n that issue is closed?~~ derp 😄

AdelheidF · 2019-10-29T23:59:40Z

1 and 2 are fixed, 3 I can handle myself if it's not considered a bug. Thanks.

pr3tori4n · 2019-10-31T17:49:13Z

@kat10140 sorry link was unintentional :) - didn't mean issue 3 but the 3rd item in Adelheides initial comment (3).

…st-render (#400) * add a console warn and simpler demo file * 3 new tests for filter. metadata wip * change filter data from to selected properties. Prior was using all attributes. * add event for modified properties filter depends on * split filter setup so it can called on prop change * fix bug in tests * remove .only from test * filter: add a warning when there is no data. * fix getTag to work with no attributes * add tests for filter * fix accessibility * change existing demo to advanced demo * change simple demo to default * wip demos * PickList and ValueList: share more code between lists 461 (#484) * remove .only from test * fix lint errors * add temporary backup files to gitignore * abstract common methods to a shared location * share selection/deselection tests * fix shiftClick behavior for valueList * abstract shared tests between lists * improve method return type * normalize render functions * add this typing to shared logic file https://stackoverflow.com/questions/54710927/typescript-types-and-bind * moving compact prop to alpha order * added typing to items * add compact property to value list * fix type error on textHeading * fix typings * update lists to use common MO callback MO: Mutation Observer * comment touchup * fix backwards compat and event typing * add missing typings * space the tests out * code review follow up * abstracted some types * move comment up * PickList and ValueList: share render methods between lists 461 (#488) * fix lint errors * add temporary backup files to gitignore * abstract common methods to a shared location * share selection/deselection tests * fix shiftClick behavior for valueList * abstract shared tests between lists * improve method return type * normalize render functions * abstract the render methods to functional comp * switch value list over to use shared render * fix calcite-block accessible test. * update calciteListItemPropsUpdated event docs * replace attribute logic with properties * minor demo changes * clean up demo * removing redundant warn message * remove maquette

pr3tori4n · 2019-11-08T19:08:31Z

@kat10140 Please verify.

kat10140 · 2019-11-08T22:00:29Z

@pr3tori4n looks like radio buttons can still be deselected

kat10140 · 2019-11-08T22:01:33Z

kat10140 · 2019-11-08T22:06:33Z

nvm, making this into separate issue

AdelheidF added the bug Something isn't working label Oct 17, 2019

AdelheidF changed the title ~~Bug:~~ Bug: calcite-pick-list issues with filter Oct 17, 2019

driskull assigned pr3tori4n Oct 18, 2019

driskull added 1 - assigned p - medium labels Oct 18, 2019

driskull added this to the Donny milestone Oct 18, 2019

AdelheidF changed the title ~~Bug: calcite-pick-list issues with filter~~ Bug: calcite-pick-list issues with filter + selection Oct 19, 2019

AdelheidF changed the title ~~Bug: calcite-pick-list issues with filter + selection~~ Bug: calcite-pick-list issues with filter + css + selection Oct 19, 2019

pr3tori4n mentioned this issue Oct 23, 2019

Hrobbins/hotfix move filter setup after render 400 #451

Merged

pr3tori4n changed the title ~~Bug: calcite-pick-list issues with filter + css + selection~~ Bug: calcite-pick-list filter is hiding all items Oct 24, 2019

pr3tori4n assigned kat10140 Oct 24, 2019

pr3tori4n mentioned this issue Oct 31, 2019

PickList and ValueList: share more code between lists 461 #484

Merged

pr3tori4n mentioned this issue Nov 5, 2019

PickList/ValueList use props not attrs 400 #499

Merged

kat10140 added 3 - installed and removed 1 - assigned labels Nov 8, 2019

pr3tori4n removed their assignment Nov 8, 2019

kat10140 assigned pr3tori4n and unassigned kat10140 Nov 8, 2019

kat10140 closed this as completed Nov 8, 2019

kat10140 added the 4 - verified label Nov 8, 2019

kat10140 unassigned pr3tori4n Nov 8, 2019

kat10140 removed the 3 - installed label Nov 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: calcite-pick-list filter is hiding all items #400

Bug: calcite-pick-list filter is hiding all items #400

AdelheidF commented Oct 17, 2019 •

edited

Loading

jbartley commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

AdelheidF commented Oct 22, 2019

jcfranco commented Oct 23, 2019

pr3tori4n commented Oct 23, 2019

pr3tori4n commented Oct 24, 2019

kat10140 commented Oct 29, 2019 •

edited

Loading

AdelheidF commented Oct 29, 2019

pr3tori4n commented Oct 31, 2019

pr3tori4n commented Nov 8, 2019

kat10140 commented Nov 8, 2019

kat10140 commented Nov 8, 2019

kat10140 commented Nov 8, 2019

Bug: calcite-pick-list filter is hiding all items #400

Bug: calcite-pick-list filter is hiding all items #400

Comments

AdelheidF commented Oct 17, 2019 • edited Loading

Summary

Actual Behavior

Expected Behavior

Reproduction Steps

Relevant Info

jbartley commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

pr3tori4n commented Oct 22, 2019

AdelheidF commented Oct 22, 2019

jcfranco commented Oct 23, 2019

pr3tori4n commented Oct 23, 2019

pr3tori4n commented Oct 24, 2019

kat10140 commented Oct 29, 2019 • edited Loading

AdelheidF commented Oct 29, 2019

pr3tori4n commented Oct 31, 2019

pr3tori4n commented Nov 8, 2019

kat10140 commented Nov 8, 2019

kat10140 commented Nov 8, 2019

kat10140 commented Nov 8, 2019

AdelheidF commented Oct 17, 2019 •

edited

Loading

kat10140 commented Oct 29, 2019 •

edited

Loading