Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: CalciteBlock - add loading and disabled properties #358

Closed
kat10140 opened this issue Oct 9, 2019 · 3 comments
Closed

Enhancement: CalciteBlock - add loading and disabled properties #358

kat10140 opened this issue Oct 9, 2019 · 3 comments
Assignees
@kat10140
Labels
4 - verified enhancement New feature request for an existing component p - high
Milestone
Donny

Comments

@kat10140
Copy link
Contributor

kat10140 commented Oct 9, 2019 •
edited
Loading

Description

Enhancement: CalciteBlock add loading & disabled properties

Acceptance Criteria

Loading and disabled boolean properties on the component.

Desired New Behavior

  • Loading should display a visual loading state on the component.
  • Disabled should display a visually disabled state on the component and prevent user interaction as necessary.
  • Loading should use any appropriate calcite-components for loading as necessary.

Desired Change to Look and Feel

Loading style and disabled style

Out of Scope

Relevant Info

Related to #248

Helpful Details

@asangma you can help me figure out what exactly needs to be blocked and what the ideal design should look like.
@kat10140 kat10140 added the enhancement New feature request for an existing component label Oct 9, 2019
@kat10140 kat10140 added this to the Donny milestone Oct 9, 2019
@kat10140 kat10140 changed the title Loading State: Block Enhancement: Loading State: Block Oct 9, 2019
@kat10140 kat10140 changed the title Enhancement: Loading State: Block Enhancement: CalciteBlock - add loading and disabled properties Oct 9, 2019
asangma added a commit that referenced this issue Oct 11, 2019
@asangma
feat(block): added calcite-loader and associated styles. Updated demo. (
a5b87c0 
#358)
asangma added a commit that referenced this issue Oct 14, 2019
@asangma
feat(block): added disabled style. updated demo with way to toggle di…
20e5ccd 
…sabled property. (#358)
@asangma asangma mentioned this issue Oct 14, 2019
Merged
asangma added a commit that referenced this issue Oct 14, 2019
@asangma
feat(block): a11y aria labels for disabled and loading (#358)
9a23101
asangma added a commit that referenced this issue Oct 14, 2019
@asangma
feat(all): blocking scrim + pick-list loading and disabled. TODO clea…
25d846e 
…n-up (#361 #357 #358 #359 #361 #362)
@asangma asangma mentioned this issue Oct 14, 2019
Merged
asangma added a commit that referenced this issue Oct 15, 2019
@asangma
feat(block): added relative to .content (#358)
333ee89
@asangma asangma assigned kat10140 and asangma and unassigned jcfranco and kat10140 Oct 17, 2019
@kat10140
Copy link
Contributor Author

kat10140 commented Oct 18, 2019 •
edited
Loading

@asangma is this on master? I'm only seeing loading prop on block. Or were you assigning this to me to add those properties to the component
I see its in PR my b

@kat10140 kat10140 assigned kat10140 and unassigned asangma Oct 18, 2019
@asangma
Copy link
Contributor

asangma commented Oct 18, 2019

@kat10140 Installed. Please verify. :)

@kat10140
Copy link
Contributor Author

Verified!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified enhancement New feature request for an existing component p - high
Projects
None yet
Milestone
Donny
Development

No branches or pull requests
3 participants
@jcfranco @asangma @kat10140