Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: calcite-panel without header text but close icon #354

Closed
AdelheidF opened this issue Oct 9, 2019 · 3 comments
Closed

Enhancement: calcite-panel without header text but close icon #354

AdelheidF opened this issue Oct 9, 2019 · 3 comments
Assignees
@AdelheidF @kat10140
Labels
4 - verified enhancement New feature request for an existing component p - low
Milestone
Donny

Comments

@AdelheidF
Copy link

Description

I changed from calcite-shell-floating-panel to calcite-panel and added dismissible=true. Then the close icon appeared on the wrong side.

1

Then we noticed that if we add an empty div for the content-header slot it works. But we don't need any text in the header. Could this be optional?

Acceptance Criteria

Desired New Behavior

Desired Change to Look and Feel

Out of Scope

Relevant Info

Helpful Details

Which Component:
Example Use Case:
@AdelheidF AdelheidF added the enhancement New feature request for an existing component label Oct 9, 2019
@driskull driskull self-assigned this Oct 9, 2019
@driskull driskull added this to the Choose Goose milestone Oct 9, 2019
@driskull
Copy link
Member

@AdelheidF I can make it so those slots are always there.

driskull added a commit that referenced this issue Oct 21, 2019
@driskull
always render slot containers. #354
0e55517
@driskull driskull mentioned this issue Oct 21, 2019
Merged
driskull added a commit that referenced this issue Oct 21, 2019
@driskull
Merge pull request #420 from Esri/dris0000/panel-slot-containers
73e0c48 
fix: CalcitePanel: always render slot containers. #354
@driskull driskull assigned AdelheidF and unassigned driskull Oct 21, 2019
@kat10140 kat10140 modified the milestones: Choose Goose, Donny Oct 21, 2019
@AdelheidF
Copy link
Author

@kat10140 I don't have this test case anymore. Could you verify? Thanks.

@kat10140 kat10140 self-assigned this Oct 23, 2019
@kat10140
Copy link
Contributor

Verified !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AdelheidF AdelheidF

@kat10140 kat10140

Labels
4 - verified enhancement New feature request for an existing component p - low
Projects
None yet
Milestone
Donny
Development

No branches or pull requests
3 participants
@driskull @AdelheidF @kat10140