Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: A shell with only a contextual panel displays on the incorrect side #259

Closed
driskull opened this issue Sep 11, 2019 · 19 comments
Closed
Assignees
Labels
4 - verified bug Something isn't working p - low question Further information is requested

Comments

@driskull
Copy link
Member

driskull commented Sep 11, 2019

Summary

Bug: A shell with only a contextual panel displays on the incorrect side

Actual Behavior

The contextual panel appears on the left side of the shell

Expected Behavior

A user must have a primary panel. In the primary panel, they can specify a layout of trailing.

Reproduction Steps

  1. Open the shell demo page
  2. Remove the primary panel node

Relevant Info

@driskull driskull added the bug Something isn't working label Sep 11, 2019
@driskull driskull added this to the BMO milestone Sep 11, 2019
@driskull
Copy link
Member Author

cc @AdelheidF

driskull added a commit that referenced this issue Sep 11, 2019
@driskull driskull modified the milestones: BMO, Choose Goose Sep 13, 2019
@driskull driskull removed their assignment Sep 16, 2019
@driskull driskull added 1 - assigned p - low question Further information is requested labels Oct 2, 2019
@driskull
Copy link
Member Author

driskull commented Oct 2, 2019

@asangma is it a valid use case to just have a contextual panel? or should we just close this as known issue or invalid?

@kat10140 kat10140 modified the milestones: Choose Goose, Donny Oct 21, 2019
@asangma asangma modified the milestones: Donny, Eberhardt Nov 7, 2019
@asangma asangma modified the milestones: Eberhardt, Fern Dec 4, 2019
@asangma asangma modified the milestones: Fern, Grob Gob Glob Grod Dec 20, 2019
@driskull driskull assigned driskull and unassigned asangma Dec 30, 2019
driskull added a commit that referenced this issue Jan 6, 2020
…ide (#709)

* A shell with only a contextual panel displays on the incorrect side #259

* use variable
@driskull
Copy link
Member Author

driskull commented Jan 6, 2020

cc @kellyhutchins

@kellyhutchins
Copy link
Member

Awesome! I'll test it out in my app

@driskull
Copy link
Member Author

driskull commented Jan 6, 2020

You'll have to wait for our next release @kellyhutchins :(

@kat10140
Copy link
Contributor

kat10140 commented Jan 6, 2020

I'm still seeing it on the left side @driskull :/

@driskull
Copy link
Member Author

driskull commented Jan 6, 2020

@kat10140 you must have a primary panel. In the primary panel, you can specify a layout of trailing.

@kat10140
Copy link
Contributor

kat10140 commented Jan 6, 2020

ok in the comment above we have:

The contextual panel should appear on the right side if just a contextual panel is used without a primary panel. 

@driskull
Copy link
Member Author

driskull commented Jan 6, 2020

Updated issue! Thanks

@kat10140
Copy link
Contributor

kat10140 commented Jan 6, 2020

Mines still not flip flopping 😫

@kat10140
Copy link
Contributor

kat10140 commented Jan 6, 2020

Screen Shot 2020-01-06 at 2 52 45 PM
i see it's technically working but the styling looks wack

@driskull
Copy link
Member Author

driskull commented Jan 6, 2020

Can you replicate /demos/shell/demo-app-full-window-reversed.html?

@kat10140
Copy link
Contributor

kat10140 commented Jan 6, 2020

Screen Shot 2020-01-06 at 2 57 35 PM

@driskull
Copy link
Member Author

driskull commented Jan 6, 2020

@kat10140 you may need to do an npm install and restart the build

@kat10140
Copy link
Contributor

kat10140 commented Jan 7, 2020

still doing the same weirdness 🤷🏼‍♀️

@driskull
Copy link
Member Author

driskull commented Jan 7, 2020

@kat10140 can you share the HTML you're using? Does the demo /demos/shell/demo-app-full-window-reversed.html look ok?

@kat10140
Copy link
Contributor

kat10140 commented Jan 7, 2020

yah it looks fine otherwise! i was deleting the contextual panel, then changing the primary panel layout property to 'trailing'

<calcite-shell-panel slot="primary-panel" layout="trailing" detached="" class="hydrated">
       ....    
 </calcite-shell-panel>

or in the reversed case, changing trailing to leading

@driskull
Copy link
Member Author

driskull commented Jan 7, 2020

If you're going to modify the layout after initialization, you'll also need to modify the action-bar to be trailing.

@kat10140
Copy link
Contributor

kat10140 commented Jan 7, 2020

the action bar actually automatically seems to change to"trailing" in the sense that it moves to the right (in the full window app). in the reversed, it looks fine when i just delete the contextual panel all together, everything stays put. i'll mark as verified

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified bug Something isn't working p - low question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants