Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: calcite-pick-list group items remain when filtering #1026

Closed
kevindoshier opened this issue Jun 29, 2020 · 6 comments
Closed

Bug: calcite-pick-list group items remain when filtering #1026

kevindoshier opened this issue Jun 29, 2020 · 6 comments
Assignees
Labels
4 - verified bug Something isn't working

Comments

@kevindoshier
Copy link

Summary

The blend layer ux in in the map viewer uses a calcite popover combined with a panel and picklist. It works well except when attempting to filter out the picklist values.

After applying a filter, all of the pick list group options continue to show. Is it possible for the groups to be hidden if it doesn’t contain one of the filtered pick list values?

pick-list

Actual Behavior

Expected Behavior

Hide the calcite-pick-list-group items when filtering

Reproduction Steps

Relevant Info

@kevindoshier kevindoshier added 0 - new bug Something isn't working labels Jun 29, 2020
@jcfranco jcfranco self-assigned this Jun 29, 2020
@jcfranco
Copy link
Member

Found the issue. The code that handles filtering doesn't account for non-nested groups (using slot=parent-item), so those groups always stay visible when there are no matches.

@jcfranco
Copy link
Member

Installed.

@AdelheidF
Copy link

Looks like there was no calcite-app-release for this one, correct?
I assume there would be a lot of other changes in a new release. Not sure if we should go for it so close to beta 7...

@AdelheidF
Copy link

Should this be part of "@esri/calcite-app-components@6.1.0-beta.9" ? I tried this locally and don't see a change.

@cwwhitmore

@cwwhitmore
Copy link

Thanks @AdelheidF for looking into this. Think at this point, it can just wait until the next beta.

@kat10140
Copy link
Contributor

looks good! closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants