fix(action, flow, pick-list, sortable-list, tip-manager, value-list):…

… react to DOM mutations earlier to avoid stagnant renders (#920) #919
Esri · Apr 7, 2020 · 700d9f8 · 700d9f8
1 parent 34f9a6b
commit 700d9f8
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 16 deletions.
diff --git a/src/components/calcite-action/calcite-action.tsx b/src/components/calcite-action/calcite-action.tsx
@@ -101,7 +101,7 @@ export class CalciteAction {
   //
   // --------------------------------------------------------------------------
 
-  componentDidLoad(): void {
+  connectedCallback(): void {
     this.observer.observe(this.el, { childList: true, subtree: true });
   }
 

diff --git a/src/components/calcite-flow/calcite-flow.tsx b/src/components/calcite-flow/calcite-flow.tsx
@@ -76,12 +76,9 @@ export class CalciteFlow {
   //
   // --------------------------------------------------------------------------
 
-  componentWillLoad(): void {
-    this.updateFlowProps();
-  }
-
-  componentDidLoad(): void {
+  connectedCallback(): void {
     this.flowItemObserver.observe(this.el, { childList: true, subtree: true });
+    this.updateFlowProps();
   }
 
   componentDidUnload(): void {

diff --git a/src/components/calcite-pick-list/calcite-pick-list.tsx b/src/components/calcite-pick-list/calcite-pick-list.tsx
@@ -110,9 +110,6 @@ export class CalcitePickList<
 
   connectedCallback(): void {
     initialize.call(this);
-  }
-
-  componentDidLoad(): void {
     initializeObserver.call(this);
   }
 

diff --git a/src/components/calcite-sortable-list/calcite-sortable-list.tsx b/src/components/calcite-sortable-list/calcite-sortable-list.tsx
@@ -68,7 +68,7 @@ export class CalciteSortableList {
   //
   // --------------------------------------------------------------------------
 
-  componentDidLoad(): void {
+  connectedCallback(): void {
     this.items = Array.from(this.el.children);
     this.setUpDragAndDrop();
     this.beginObserving();

diff --git a/src/components/calcite-tip-manager/calcite-tip-manager.tsx b/src/components/calcite-tip-manager/calcite-tip-manager.tsx
@@ -137,9 +137,6 @@ export class CalciteTipManager {
 
   connectedCallback(): void {
     this.setUpTips();
-  }
-
-  componentDidLoad(): void {
     this.observer.observe(this.el, { childList: true, subtree: true });
   }
 

diff --git a/src/components/calcite-value-list/calcite-value-list.tsx b/src/components/calcite-value-list/calcite-value-list.tsx
@@ -119,9 +119,6 @@ export class CalciteValueList<
   // --------------------------------------------------------------------------
   connectedCallback(): void {
     initialize.call(this);
-  }
-
-  componentDidLoad(): void {
     this.setUpDragAndDrop();
     initializeObserver.call(this);
   }