feat!: BREAKING CHANGE rename secondary-action slot

Co-authored-by: Matt Driscoll <driskull@users.noreply.github.com>
Esri · Jan 6, 2020 · 4569a57 · 4569a57
1 parent e1af1d6
commit 4569a57
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/components/calcite-pick-list-item/calcite-pick-list-item.tsx b/src/components/calcite-pick-list-item/calcite-pick-list-item.tsx
@@ -13,7 +13,7 @@ import { CSS, ICONS } from "./resources";
 import { ICON_TYPES } from "../calcite-pick-list/resources";
 
 /**
- * @slot secondaryAction - A slot intended for adding a `calcite-action` or `calcite-button` to the right side of the card.
+ * @slot secondary-action - A slot intended for adding a `calcite-action` or `calcite-button` to the right side of the card.
  * This is placed at the end of the item.
  */
 @Component({
@@ -218,7 +218,7 @@ export class CalcitePickListItem {
           </div>
         </label>
         <div class={CSS.action}>
-          <slot name="secondaryAction" />
+          <slot name="secondary-action" />
         </div>
       </Host>
     );

diff --git a/src/components/calcite-pick-list/calcite-pick-list.stories.ts b/src/components/calcite-pick-list/calcite-pick-list.stories.ts
@@ -53,7 +53,7 @@ const createAttributes: () => Attributes = () => [
   }
 ];
 
-const action = `<calcite-action slot="secondaryAction" label="click-me" onClick="console.log('clicked');" appearance="clear">
+const action = `<calcite-action slot="secondary-action" label="click-me" onClick="console.log('clicked');" appearance="clear">
   <svg width="16" height="16" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16">
     <circle cx="7" cy="7" r="7" fill="#f689d8" />
   </svg>

diff --git a/src/components/calcite-value-list-item/calcite-value-list-item.tsx b/src/components/calcite-value-list-item/calcite-value-list-item.tsx
@@ -5,7 +5,7 @@ import { CSS } from "../calcite-pick-list-item/resources";
 import { ICONS } from "./resources";
 
 /**
- * @slot secondaryAction - A slot intended for adding a `calcite-action` or `calcite-button`. This is placed at the end of the item.
+ * @slot secondary-action - A slot intended for adding a `calcite-action` or `calcite-button`. This is placed at the end of the item.
  */
 @Component({
   tag: "calcite-value-list-item",
@@ -154,7 +154,7 @@ export class CalciteValueListItem {
           onCalciteListItemChange={this.handleSelectChange}
           value={this.value}
         >
-          <slot name="secondaryAction" slot="secondaryAction" />
+          <slot name="secondary-action" slot="secondary-action" />
         </calcite-pick-list-item>
       </Host>
     );

diff --git a/src/components/calcite-value-list/calcite-value-list.stories.ts b/src/components/calcite-value-list/calcite-value-list.stories.ts
@@ -57,7 +57,7 @@ const createAttributes: () => Attributes = () => [
   }
 ];
 
-const action = `<calcite-action slot="secondaryAction" label="click-me" onClick="console.log('clicked');" appearance="clear">
+const action = `<calcite-action slot="secondary-action" label="click-me" onClick="console.log('clicked');" appearance="clear">
   <svg width="16" height="16" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16">
     <circle cx="7" cy="7" r="7" fill="#f689d8" />
   </svg>