-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "layers" parameter of IExportParameters optional #775
Conversation
…ters\` optional AFFECTS PACKAGES: @esri/arcgis-rest-portal
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 120 120
Lines 1915 1915
Branches 325 325
=========================================
Hits 1915 1915
Continue to review full report at Codecov.
|
But this says |
@tomwayson - it does say that, but in fact, it is not true. I've tested it and can send you the curl if you like. There are cases where you want to export all layers but still set a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only suggestion would be to put this into a code comment:
Confirmed that the docs are out of date; will add code-comment to note the discrepancy. |
@rgwozdz fyi - CI fails on node 15.1.0 due to npm/cli#2084 |
@dbouwman - would it help if I do a separate PR for removing latest Node from Travis? |
We want the option of not setting
layers
in IExportParameters. That will force the /export service to include all the layers in the delivered export.