feat(vid): port VID from another repo #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #336
A direct port of
vid
from hotshot-primitives repo. Nontrivial changes:test-srs
feature. (This was much easier from another repo becausetest-srs
could be specified in a dev-dependency inCargo.toml
, but there seems to be no idiomatic way to enable a feature of the present crate only for test/bench code 😢 .)no_std
. Remove use ofthiserror
crate, which is notno_std
compatible, and tweak associated error-handling code.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer