Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vid): port VID from another repo #337

Merged
merged 6 commits into from
Jul 4, 2023
Merged

feat(vid): port VID from another repo #337

merged 6 commits into from
Jul 4, 2023

Conversation

ggutoski
Copy link
Contributor

@ggutoski ggutoski commented Jul 3, 2023

Description

closes: #336

A direct port of vid from hotshot-primitives repo. Nontrivial changes:

  • Feature-gate tests with test-srs feature. (This was much easier from another repo because test-srs could be specified in a dev-dependency in Cargo.toml, but there seems to be no idiomatic way to enable a feature of the present crate only for test/bench code 😢 .)
  • Support no_std. Remove use of thiserror crate, which is not no_std compatible, and tweak associated error-handling code.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@ggutoski ggutoski requested a review from alxiong July 3, 2023 19:44
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gus! generally LGTM, left a few comments.

plonk/src/circuit/plonk_verifier/gadgets.rs Outdated Show resolved Hide resolved
primitives/src/vid/mod.rs Show resolved Hide resolved
primitives/tests/advz.rs Show resolved Hide resolved
primitives/src/vid/mod.rs Show resolved Hide resolved
@ggutoski ggutoski requested a review from alxiong July 4, 2023 15:36
@ggutoski ggutoski merged commit 2ed9124 into main Jul 4, 2023
3 checks passed
@ggutoski ggutoski deleted the port-vid branch July 4, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port VID code into this repo
2 participants