Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: quality-of-life improvements for HasherMerkleTree and bytes_to_field_elements #335

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

ggutoski
Copy link
Contributor

@ggutoski ggutoski commented Jul 3, 2023

Description

closes: #334


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@ggutoski ggutoski assigned mrain and unassigned mrain Jul 3, 2023
@ggutoski ggutoski requested a review from mrain July 3, 2023 17:24
mrain
mrain previously approved these changes Jul 5, 2023
Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! neat

@ggutoski ggutoski requested a review from mrain July 5, 2023 16:08
@ggutoski ggutoski merged commit f297080 into main Jul 5, 2023
3 checks passed
@ggutoski ggutoski deleted the qol branch July 5, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quality-of-life improvements for HasherMerkleTree and bytes_to_field_elements
2 participants