hardware wallets can now create safe multisig wallet tx proposals #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysiahuggins
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
alysiahuggins
requested review from
Ancient123
and removed request for
philippecamacho,
nomaxg,
jbearer,
ImJeremyHe,
imabdulbasit and
tbro
Ancient123
approved these changes
Sep 20, 2024
Ancient123
deleted the
2021-change-the-safe-wallet-orchestrator-for-proposing-transactions-to-the-safe-wallet-to-use-a-hardware-wallet-instead-of-a-private-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2021
safe multisig wallet transaction proposals are used to execute admin only operations such as
setPermissionedProver,upgradeToAndCallon the upgradeable contracts.This PR:
Key places to review:
How to test this PR:
Things tested
setPermissionedProver&upgradeToAndCallsucceed using a ledger