Update hotshot-builder-core to fix deadlock #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayiga
requested review from
nomaxg,
philippecamacho,
ImJeremyHe and
sveitser
as code owners
Ayiga
force-pushed
the
ts/fix-deadlock-in-builder-ore
branch
from
233cd37
to
3fa09bd
Compare
Oops. Missed that one. Thanks for the heads up! |
Ayiga
force-pushed
the
ts/fix-deadlock-in-builder-ore
branch
from
3fa09bd
to
a32666f
Compare
imabdulbasit
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Updates the dependency of
hotshot-builder-coreto fix a deadlock that would prevent the builder from generating new blocks. This allowsdemo-nativeanddockerdemos to work and make progress with new blocks without stopping almost immediately.This PR does not:
Address any other currently known issues within the builder.