Fix compose file configuration for node-validator and block-explorer #1833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix docker-compose and process-compose for node-validator
The
node-validator
section of thedocker-compose.yaml
file has the environment variableESPRESSO_NODE_VALIDATOR_INITIAL_NODE_PUBLIC_BASE_URLS
pointing at the incorrectports for all of the sequencers that are not
sequencer0
. As a result, the other sequencers arenot correctly scraped and are not reflected in the data collected. Additionally, the port that the
node-validator
is meant to expose is not being forwarded to the container via the environmentvariable
ESPRESSO_NODE_VALIDATOR_PORT
. Finally, the local demo service doesn't produceany visible logs while running.
Forwards the relevant needed environment variables for logging, and modifies the the ports in
the node public base URLs to correct the issue.
Add node validator configuration to process-compose and docker-compose
The block-explorer now has support for the node validator API, but has not been updated to point
to the relevant base URL for the service. As a result, the Nodes Page will still generate fake data.
Updates the process-compose.yaml and docker-compose.yaml configuration to supply the
environment variable
NODE_VALIDATOR_URI
so that it points to thenode-validator
as awebsocket connection.
Closes #1832
This PR:
Corrects the configuration of the
node-validator
by ensuring that logging is enabled for the service. Additionally, it corrects the list of initial public api urls supplied, by utilizing the internal port in thedocker-compose
file instead of the external exposed port.Adds the node-validator url to the block-explorer in order to for the
Nodes Page
to reflect the dataof the local demo instead of just producing a bunch of fake data.
Key places to review:
How to test this PR:
or
With docker-compose, make sure you have the latest images by running the following:
Then, once things are up and running, visit the block-explorer, and navigate to the Nodes Page to see updating data for the local block-chain and nodes. Please note that we've supplied fake node identity information for the nodes.