Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compose file configuration for node-validator and block-explorer #1833

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Ayiga
Copy link
Member

@Ayiga Ayiga commented Aug 8, 2024

Fix docker-compose and process-compose for node-validator

The node-validator section of the docker-compose.yaml file has the environment variable
ESPRESSO_NODE_VALIDATOR_INITIAL_NODE_PUBLIC_BASE_URLS pointing at the incorrect
ports for all of the sequencers that are not sequencer0. As a result, the other sequencers are
not correctly scraped and are not reflected in the data collected. Additionally, the port that the
node-validator is meant to expose is not being forwarded to the container via the environment
variable ESPRESSO_NODE_VALIDATOR_PORT. Finally, the local demo service doesn't produce
any visible logs while running.

Forwards the relevant needed environment variables for logging, and modifies the the ports in
the node public base URLs to correct the issue.

Add node validator configuration to process-compose and docker-compose

The block-explorer now has support for the node validator API, but has not been updated to point
to the relevant base URL for the service. As a result, the Nodes Page will still generate fake data.

Updates the process-compose.yaml and docker-compose.yaml configuration to supply the
environment variable NODE_VALIDATOR_URI so that it points to the node-validator as a
websocket connection.

Closes #1832

This PR:

Corrects the configuration of the node-validator by ensuring that logging is enabled for the service. Additionally, it corrects the list of initial public api urls supplied, by utilizing the internal port in the docker-compose file instead of the external exposed port.

Adds the node-validator url to the block-explorer in order to for the Nodes Page to reflect the data
of the local demo instead of just producing a bunch of fake data.

Key places to review:

  • process-compose.yaml
  • docker-compose.yaml

How to test this PR:

just demo-native

or

docker-compose up -d

With docker-compose, make sure you have the latest images by running the following:

docker-compose pull

Then, once things are up and running, visit the block-explorer, and navigate to the Nodes Page to see updating data for the local block-chain and nodes. Please note that we've supplied fake node identity information for the nodes.

Fix docker-compose and process-compose for node-validator

The `node-validator` section of the `docker-compose.yaml` file has the environment variable
`ESPRESSO_NODE_VALIDATOR_INITIAL_NODE_PUBLIC_BASE_URLS` pointing at the incorrect
ports for all of the sequencers that are not `sequencer0`.  As a result, the other sequencers are
not correctly scraped and are not reflected in the data collected.  Additionally, the port that the
`node-validator` is meant to expose is not being forwarded to the container via the environment
variable `ESPRESSO_NODE_VALIDATOR_PORT`.  Finally, the local demo service doesn't produce
any visible logs while running.

Forwards the relevant needed environment variables for logging, and modifies the the ports in
the node public base URLs to correct the issue.

Add node validator configuration to process-compose and docker-compose

The block-explorer now has support for the node validator API, but has not been updated to point
to the relevant base URL for the service.  As a result, the Nodes Page will still generate fake data.

Updates the process-compose.yaml and docker-compose.yaml configuration to supply the
environment variable `NODE_VALIDATOR_URI` so that it points to the `node-validator` as a
websocket connection.
@Ayiga Ayiga force-pushed the ts/fix/block-explorer-node-validator-configuration branch from eb7422e to e0b77f2 Compare August 8, 2024 20:37
@Ayiga Ayiga merged commit f1270db into main Aug 8, 2024
15 checks passed
@Ayiga Ayiga deleted the ts/fix/block-explorer-node-validator-configuration branch August 8, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants