Fix ubuntu build #1214
Fix ubuntu build #1214
Conversation
sveitser
commented
Mar 8, 2024
sveitser
commented
- Install postgres client, just
- Make it easier to test locally with docker
- Run with code in repo
- Fix contracts script name for latest foundry
- Skip SQL tests
- Less fuzz runs
- Install postgres client, just - Make it easier to test locally with docker - Run with code in repo - Fix contracts script name for latest foundry - Skip SQL tests - Less fuzz runs
|
CI run for the ubuntu install test job: https://github.com/EspressoSystems/espresso-sequencer/actions/runs/8204872112 |
|
This is currently broken because foundryup downloads to XDG_CONFIG_HOME if that exists 🤦 |
sveitser
requested review from
nomaxg,
philippecamacho,
ImJeremyHe and
jbearer
as code owners
| trap cleanup EXIT | ||
| cleanup(){ | ||
| echo "Cleaning up repo copy: $REPO_COPY_DIR, need sudo" | ||
| sudo rm -rf "$REPO_COPY_DIR" |
There was a problem hiding this comment.
We shouldn't need sudo to remove a directory created by normal user. Same user should be able to delete.
There was a problem hiding this comment.
Files will be owned by root because running in docker container.
|
|
||
| git clone --recursive . "$REPO_COPY_DIR" | ||
|
|
||
| # Run the installation and tests inside the container. |
There was a problem hiding this comment.
Since we are using docker anyway, instead of mounting a dir, couldn't we copy the build script into an ubuntu container and do all the git clone inside the container? This way everything is ephemeral and no need for external temp dirs.
There was a problem hiding this comment.
It's done like this now so you can get local changes that aren't yet on github inside the container. The script is just for local debugging.
