Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction with support for multiple namespaces #1205

Merged
merged 1 commit into from
Mar 8, 2024
Merged

transaction with support for multiple namespaces #1205

merged 1 commit into from
Mar 8, 2024

Conversation

akonring
Copy link
Contributor

@akonring akonring commented Mar 7, 2024

closes: #1204

Currently, the Querypayload::transaction is broken such that it only returns correct transaction if VmId indeed is 0 and there is only a single namespace:

Transaction::new(
                crate::VmId(0),
                self.raw_payload.get(tx_payload_range.clone())?.to_vec(),
            ),

This PR follows up on #1191 to have `Querypayload::transaction support multiple namespaces.

Copy link
Member

@jbearer jbearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the local demo, the load generator is now receiving confirmations of the transactions it submits, which means the reported hashes must be matching the actual hashes. So I think this is working.

Copy link
Contributor

@ggutoski ggutoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to review on a phone but I see no problems.

@akonring akonring merged commit 2eba5a8 into main Mar 8, 2024
12 checks passed
@akonring akonring deleted the ak/1204 branch March 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryablePayload::transaction with support for multiple namespaces
3 participants