add TODOs

EspressoSystems · Oct 2, 2024 · 0becffb · 0becffb
1 parent 0f4ebc0
commit 0becffb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/types/src/v0/impls/header.rs b/types/src/v0/impls/header.rs
@@ -1374,6 +1374,7 @@ mod test_headers {
 
     #[async_std::test]
     async fn test_validate_proposal_error_cases() {
+        // TODO add assertion for timestamp validation
         let genesis = GenesisForTest::default().await;
         let vid_common = vid_scheme(1).disperse([]).unwrap().common;
 

diff --git a/types/src/v0/impls/state.rs b/types/src/v0/impls/state.rs
@@ -322,6 +322,7 @@ pub fn validate_proposal(
     }
 
     // Validate timestamp increasing.
+    // TODO add test https://github.com/EspressoSystems/espresso-sequencer/issues/2100
     if proposal.timestamp() < parent_header.timestamp() {
         return Err(ProposalValidationError::InvalidTimestampNonIncrementing {
             proposal_timestamp: proposal.timestamp(),
@@ -698,6 +699,7 @@ impl HotShotState<SeqTypes> for ValidatedState {
             .expect("Chain Config not found in validated state");
 
         // Validate l1_finalized.
+        // TODO add test https://github.com/EspressoSystems/espresso-sequencer/issues/2100
         let proposed_finalized = proposed_header.l1_finalized();
         let parent_finalized = parent_leaf.block_header().l1_finalized();
         if proposed_finalized < parent_finalized {
@@ -718,8 +720,8 @@ impl HotShotState<SeqTypes> for ValidatedState {
                 return Err(BlockError::InvalidBlockHeader);
             }
         }
-
         // Validate `l1_head`.
+        // TODO add test https://github.com/EspressoSystems/espresso-sequencer/issues/2100
         if proposed_header.l1_head() < parent_leaf.block_header().l1_head() {
             tracing::error!("Invalid proposal: l1_head decreasing");
             return Err(BlockError::InvalidBlockHeader);