Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with extracting capture groups using split() #4126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

defitricks
Copy link

This PR:

Fixes the issue with using split() for extracting capture groups, replacing it with match() for more accurate group extraction.

This PR does not:

Introduce any new features or break existing functionality outside of the regex fix.

Key places to review:

  • Regex logic where the capture groups are now handled using match() instead of split().

How to test this PR:

Ensure that the regex now correctly extracts the expected groups and behaves as intended across different test cases.

@defitricks defitricks requested a review from bfish713 as a code owner February 20, 2025 16:54
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants