create table technical design #71

lordpixel · 2020-08-24T23:08:29Z

This is a draft of the technical design for Table.
It's still in progress but I think it's good enough to start the discussion.

packages/cascara/src/ui/Table/TechnicalDesign.mdx

brianespinosa

Let's also have Allie take a look at this tomorrow with us. We can keep commenting on the code and have discussions over spec. Let's see what we do and do not like about this process in general too. At the end of the month we can set up a meeting to discuss if we think we have an idea on what our official process for spec or tech design review and approvals should look like.

packages/cascara/src/ui/Table/TechnicalDesign.mdx

brianespinosa · 2020-08-25T00:24:45Z

packages/cascara/src/ui/Table/TechnicalDesign.mdx

+
+The data types this table can handle are the following:
+
+For display puposes: `boolean`, `date`, `image`, `link`, `number`, `string` and `render`. The `render` type being a custom JSX.


We should figure out how to identify which of these is part of MVP and which is future.

Also, we need to figure out what these little guys are called. They will be used in a reusable manner all over Cascara. Basically they are like display atoms or something. And they will have an editing experience as well.

Maybe we just call these guys "atoms". And for all atoms they have an editing or display presentation?

yes, atoms is a more descriptive term.

@brianespinosa, I double-checked the apps to see which atoms are to be included in the MVP.
The lists are the following:

Display

boolean

date

link

number

string

Edit

switch

input

datetime picker

select

lookup select

The atoms we use fordisplay will be different to the atoms we use for edit, that doubles the effort.

For "edit" the experience needs to be more simple for MVP. I think for boolean we can only do a default html checkbox. For date, we should show an input date time field, not our own date picker. Basically the edit experience for MVP is going to be: whatever is available in html and what do browser vendors provide natively. We will absolutely have other options though in the future:

switch versus checkbox for booleans

custom date picker to be consistent across all browsers (except I think keeping native pickers on mobile)

custom select/dropwdown component of our own so we can control the UI/UX (again I think the exception would be mobile)

lots of others

Ok sounds good! Thanks for reminding me about HTML5, the mobile functionality aspect is very important.

I mentioned the switch instead of checkbox because wee have tables that implement it. At the end of the day we can style an HTML5 checkbox to make it look/behave as a switch. I have some ideas on that matter that I want to explore and run by @CaffeinatedAllie.

Yep. I think with these atoms, there are also use cases where we will want a checkbox too. Eventually someone could decide which control they want to show for their boolean. Does a checkbox, a switch, an enum select make the most sense?

yes, they completely make sense. The enum select will have the true, false values - we could also allow the user to set the labels to support localizaton.

You just uncovered a track we can start to follow in terms of abstraction, looking forward to it!

I will start typing these ideas into code soon, these kind of convos make really think about implementation! 🙌

brianespinosa · 2020-08-25T00:31:20Z

packages/cascara/src/ui/Table/TechnicalDesign.mdx

+
+## Context
+
+All the internal logic will be hosted in a Context. The definition is WIP.


Okay, I can tell this is specific to React context. 👍🏽 Moving forward, any time we are referring to something that is part of React as part of the API, or any other tool as part of the API, we should figure out a consistent way of calling that out. We have a lot of terms in our ecosystem that have special meaning which we want to be clear on.

yup, that's React Context. I will make it clear throught the document.

packages/cascara/src/ui/Table/TechnicalDesign.mdx

thanks! Co-authored-by: Brian Espinosa <brianespinosa@users.noreply.github.com>

brianespinosa · 2020-08-25T20:31:48Z

packages/cascara/src/ui/Table/TechnicalDesign.mdx

@@ -142,3 +142,34 @@ For mutation purposes, the implementation will support `select`, `input`, `boole
 ## Context

 All the internal logic will be hosted in a Context. The definition is WIP.
+
+![Table API](data:image/png;base64,<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="661px" height="461px" viewBox="-0.5 -0.5 661 461"><defs/><g><rect x="540" y="170" width="80" height="20" fill="none" stroke="none" pointer-events="all"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe flex-start; width: 78px; height: 1px; padding-top: 180px; margin-left: 542px;"><div style="box-sizing: border-box; font-size: 0; text-align: left; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; white-space: normal; word-wrap: normal; ">onCreate</div></div></div></foreignObject><text x="542" y="184" fill="#000000" font-family="Helvetica" font-size="12px" font-weight="bold">onCreate</text></switch></g><rect x="540" y="210" width="80" height="20" fill="none" stroke="none" pointer-events="all"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe flex-start; width: 78px; height: 1px; padding-top: 220px; margin-left: 542px;"><div style="box-sizing: border-box; font-size: 0; text-align: left; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; white-space: normal; word-wrap: normal; ">onDelete</div></div></div></foreignObject><text x="542" y="224" fill="#000000" font-family="Helvetica" font-size="12px" font-weight="bold">onDelete</text></switch></g><rect x="540" y="250" width="80" height="20" fill="none" stroke="none" pointer-events="all"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe flex-start; width: 78px; height: 1px; padding-top: 260px; margin-left: 542px;"><div style="box-sizing: border-box; font-size: 0; text-align: left; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; white-space: normal; word-wrap: normal; ">onUpdate</div></div></div></foreignObject><text x="542" y="264" fill="#000000" font-family="Helvetica" font-size="12px" font-weight="bold">onUpdate</text></switch></g><rect x="540" y="290" width="120" height="20" fill="none" stroke="none" pointer-events="all"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe flex-start; width: 118px; height: 1px; padding-top: 300px; margin-left: 542px;"><div style="box-sizing: border-box; font-size: 0; text-align: left; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; white-space: normal; word-wrap: normal; ">onCustomAction</div></div></div></foreignObject><text x="542" y="304" fill="#000000" font-family="Helvetica" font-size="12px" font-weight="bold">onCustomAction</text></switch></g><path d="M 315 190 L 360 211.61 L 360 268.39 L 315 290 L 270 268.39 L 270 211.61 Z" fill="#ffffff" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/><path d="M 270 211.61 L 315 233.21 L 360 211.61 M 315 233.21 L 315 290" fill="none" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe flex-start; justify-content: unsafe center; width: 88px; height: 1px; padding-top: 204px; margin-left: 271px;"><div style="box-sizing: border-box; font-size: 0; text-align: center; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; white-space: normal; word-wrap: normal; ">Props</div></div></div></foreignObject><text x="315" y="216" fill="#000000" font-family="Helvetica" font-size="12px" text-anchor="middle" font-weight="bold">Props</text></switch></g><path d="M 540 160 L 524.39 160 Q 514.39 160 514.39 170 L 514.39 230 Q 514.39 240 504.39 240 L 497.2 240 Q 490 240 500 240 L 507.2 240 Q 514.39 240 514.39 250 L 514.39 310 Q 514.39 320 524.39 320 L 540 320" fill="none" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/><path d="M 360 240 L 495 240" fill="none" stroke="#000000" stroke-miterlimit="10" pointer-events="stroke"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe center; width: 1px; height: 1px; padding-top: 240px; margin-left: 428px;"><div style="box-sizing: border-box; font-size: 0; text-align: center; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; background-color: #ffffff; white-space: nowrap; "> events </div></div></div></foreignObject><text x="428" y="244" fill="#000000" font-family="Helvetica" font-size="12px" text-anchor="middle" font-weight="bold"> events </text></switch></g><path d="M 130 160 L 114.39 160 Q 104.39 160 104.39 170 L 104.39 230 Q 104.39 240 94.39 240 L 87.2 240 Q 80 240 90 240 L 97.2 240 Q 104.39 240 104.39 250 L 104.39 310 Q 104.39 320 114.39 320 L 130 320" fill="none" stroke="#000000" stroke-miterlimit="10" transform="rotate(180,105,240)" pointer-events="all"/><path d="M 270 240 L 125 240" fill="none" stroke="#000000" stroke-miterlimit="10" pointer-events="stroke"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe center; width: 1px; height: 1px; padding-top: 240px; margin-left: 197px;"><div style="box-sizing: border-box; font-size: 0; text-align: center; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; background-color: #ffffff; white-space: nowrap; "> config </div></div></div></foreignObject><text x="197" y="244" fill="#000000" font-family="Helvetica" font-size="12px" text-anchor="middle" font-weight="bold"> config </text></switch></g><rect x="0" y="170" width="100" height="140" fill="none" stroke="none" pointer-events="all"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe flex-start; justify-content: unsafe flex-start; width: 98px; height: 1px; padding-top: 177px; margin-left: 2px;"><div style="box-sizing: border-box; font-size: 0; text-align: left; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; white-space: normal; word-wrap: normal; ">Bulk<br /><br />Columns<br /><br />Create<br /><br />Delete<br /><br />Update</div></div></div></foreignObject><text x="2" y="189" fill="#000000" font-family="Helvetica" font-size="12px" font-weight="bold">Bulk...</text></switch></g><path d="M 315 190 L 315 83.04" fill="none" stroke="#000000" stroke-miterlimit="10" pointer-events="stroke"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe center; width: 1px; height: 1px; padding-top: 137px; margin-left: 315px;"><div style="box-sizing: border-box; font-size: 0; text-align: center; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; background-color: #ffffff; white-space: nowrap; "> data </div></div></div></foreignObject><text x="315" y="141" fill="#000000" font-family="Helvetica" font-size="12px" text-anchor="middle" font-weight="bold"> data </text></switch></g><path d="M 285 15 C 285 6.72 298.43 0 315 0 C 322.96 0 330.59 1.58 336.21 4.39 C 341.84 7.21 345 11.02 345 15 L 345 65 C 345 73.28 331.57 80 315 80 C 298.43 80 285 73.28 285 65 Z" fill="#ffffff" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/><path d="M 345 15 C 345 23.28 331.57 30 315 30 C 298.43 30 285 23.28 285 15" fill="none" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/><path d="M 315 290 L 315 400" fill="none" stroke="#000000" stroke-miterlimit="10" pointer-events="stroke"/><g transform="translate(-0.5 -0.5)"><switch><foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"><div xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe center; justify-content: unsafe center; width: 1px; height: 1px; padding-top: 345px; margin-left: 315px;"><div style="box-sizing: border-box; font-size: 0; text-align: center; "><div style="display: inline-block; font-size: 12px; font-family: Helvetica; color: #000000; line-height: 1.2; pointer-events: all; font-weight: bold; background-color: #ffffff; white-space: nowrap; ">triggers</div></div></div></foreignObject><text x="315" y="349" fill="#000000" font-family="Helvetica" font-size="12px" text-anchor="middle" font-weight="bold">triggers</text></switch></g><path d="M 280 410 L 370 410 L 370 460 L 280 460 Z" fill="#ffffff" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/><path d="M 275 405 L 365 405 L 365 455 L 275 455 Z" fill="#ffffff" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/><path d="M 270 400 L 360 400 L 360 450 L 270 450 Z" fill="#ffffff" stroke="#000000" stroke-miterlimit="10" pointer-events="all"/></g><switch><g requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"/><a transform="translate(0,-5)" xlink:href="https://desk.draw.io/support/solutions/articles/16000042487" target="_blank"><text text-anchor="middle" font-size="10px" x="50%" y="100%">Viewer does not support full SVG 1.1</text></a></switch></svg>)
+


haha holy crap. That is a lot. This is going to make it difficult to work with our files if we have to jump over big data IDs. I wonder if there is a way to define these big chunks of data as reusable links at the foot of a MDX file. That way if we DO want to do this and not just place a file relative to the file itself, the big chunks of base64 are at the bottom of the document.

Not sure if reusable links will work with base64 images but could we try it?

nahh, it didn't work 😞
but, we now have svg diagrams!

packages/cascara/src/ui/Table/TechnicalDesign.mdx

brianespinosa · 2020-08-26T20:53:03Z

Updated with develop. As soon as checks pass again, will merge. Thank you @lordpixel

this is an example

brianespinosa · 2020-08-27T03:05:16Z

docs/src/pages/docs/[[...mdx]].js

+
+  // We need to make sure this is only actual files and not a directory
+  // so we are filtering it to make sure the size of the file is not zero.
+  const mdxDirFiles = mdxDir.filter((file) => file.size > 0 && file);


This is to make sure we are trying to parse MDX for actual MDX files and not a directory.

create table technical design

76d7770

brianespinosa reviewed Aug 24, 2020

View reviewed changes

packages/cascara/src/ui/Table/TechnicalDesign.mdx Show resolved Hide resolved

brianespinosa reviewed Aug 25, 2020

View reviewed changes

packages/cascara/src/ui/Table/TechnicalDesign.mdx Outdated Show resolved Hide resolved

lordpixel and others added 11 commits August 24, 2020 20:43

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

78b14d4

thanks! Co-authored-by: Brian Espinosa <brianespinosa@users.noreply.github.com>

create table technical design

b06a817

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

b2271ed

thanks! Co-authored-by: Brian Espinosa <brianespinosa@users.noreply.github.com>

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

abdb608

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

ab4841a

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

1deac9e

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

e97fe7b

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

f7572d6

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

6d8f151

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

7f5e8f2

add JSX example, plus an image try

a5f5061

brianespinosa reviewed Aug 25, 2020

View reviewed changes

lordpixel force-pushed the spec/table branch from ed94208 to a851618 Compare August 25, 2020 20:43

add props diagram

5364c53

lordpixel force-pushed the spec/table branch from a851618 to 5364c53 Compare August 25, 2020 20:47

CaffeinatedAllie reviewed Aug 25, 2020

View reviewed changes

packages/cascara/src/ui/Table/TechnicalDesign.mdx Show resolved Hide resolved

brianespinosa previously approved these changes Aug 26, 2020

View reviewed changes

Merge branch 'develop' into spec/table

84fab89

brianespinosa and others added 2 commits August 26, 2020 15:01

Merge branch 'develop' into spec/table

741b230

Update packages/cascara/src/ui/Table/TechnicalDesign.mdx

eae4385

this is an example

lordpixel dismissed brianespinosa’s stale review via eae4385 August 26, 2020 22:10

brianespinosa and others added 3 commits August 26, 2020 19:10

Merge branch 'develop' into spec/table

2f43a55

Make the docs work ONLY for MDX files, not dirs

29ab109

Merge branch 'develop' into spec/table

2a755fa

brianespinosa reviewed Aug 27, 2020

View reviewed changes

brianespinosa approved these changes Aug 27, 2020

View reviewed changes

brianespinosa merged commit d7a18a2 into develop Aug 27, 2020

brianespinosa deleted the spec/table branch August 27, 2020 03:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create table technical design #71

create table technical design #71

lordpixel commented Aug 24, 2020

brianespinosa left a comment

brianespinosa Aug 25, 2020

lordpixel Aug 25, 2020

lordpixel Aug 25, 2020

brianespinosa Aug 25, 2020

lordpixel Aug 25, 2020

brianespinosa Aug 25, 2020

lordpixel Aug 25, 2020

lordpixel Aug 25, 2020

brianespinosa Aug 25, 2020

lordpixel Aug 25, 2020

brianespinosa Aug 25, 2020 •

edited by lordpixel

Loading

lordpixel Aug 25, 2020

brianespinosa commented Aug 26, 2020

brianespinosa Aug 27, 2020


		The data types this table can handle are the following:

		For display puposes: `boolean`, `date`, `image`, `link`, `number`, `string` and `render`. The `render` type being a custom JSX.


		## Context

		All the internal logic will be hosted in a Context. The definition is WIP.

create table technical design #71

create table technical design #71

Conversation

lordpixel commented Aug 24, 2020

brianespinosa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brianespinosa Aug 25, 2020 • edited by lordpixel Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brianespinosa commented Aug 26, 2020

Choose a reason for hiding this comment

brianespinosa Aug 25, 2020 •

edited by lordpixel

Loading