-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fds 116 - Set up onAction function for feature parity with Table #141
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/espressive/cascara/gf21cj13b |
Vercel build is failing because now Table and Form import their own My guess is that we should only import Table's ActionEdit and leave Form's out. |
Interesting. Let me take a look at this. Maybe we will need to import and export those directly from the components they are used in. For instance in Form.js:
|
52275bc
to
de66705
Compare
de66705
to
653524f
Compare
653524f
to
1648d3c
Compare
1648d3c
to
754fd9c
Compare
754fd9c
to
291ba6d
Compare
1894dd4
to
ea310b9
Compare
ea310b9
to
090b6d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lordpixel we have some conflicts here. Please resolve those and then @ me so I can come back and review and test. I think we can get this in today... and possibly get the docs ready to go to also include this in the next alpha. I think this can ship as part of a new minor version 0.3.0. 🥳
090b6d0
to
e55b5e5
Compare
e55b5e5
to
b277c4b
Compare
Hi team,
This adds actions to Form, here's what was done:
Unit tests
Unit tests will be added as part of FDS-30.
ActionBar layout
As you may notice, the buttons appear at the left side. We need to talk about the layout we are going to support as well as the AST to declare it.
New Component Checklist
React.forwardRef()
when a single DOM node is returned, AND it makes React-sense to access that DOM node