Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel button to Rate and update styles for new design. #335

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

myslaf
Copy link
Contributor

@myslaf myslaf commented Mar 5, 2024

Change icons and update styles for Rating component.
Add cancel button to Rate and update styles for new design.

Change icons and update styles for Rating component.
@victazzz victazzz merged commit d2d5c9b into main Mar 5, 2024
7 of 9 checks passed
Copy link

github-actions bot commented Mar 5, 2024

AXE a11y errors violations

5 accessibility violations were detected

id impact description nodes
aria-command-name serious Ensures every ARIA button, link and menuitem has an accessible name 5
color-contrast serious Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds 2
label critical Ensures every form element has a label 2
landmark-unique moderate Landmarks should have a unique role or role/label/title (i.e. accessible name) combination 2
nested-interactive serious Ensures interactive controls are not nested as they are not always announced by screen readers or can cause focus problems for assistive technologies 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants