Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Variable Notification Window Height #415

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

modestbadger1773
Copy link

Allows Variable Notification Window Height

Solves:

@/issues/174
@/issues/274
@/issues/177

swayncwindowheight

MAX_HEIGHT is now dependent on the variable ConfigModel.instance.notification_window_height
Introduce variable notification_window_height
@ErikReider
Copy link
Owner

The issue with this is that the layer could extend past the outputs bounds if the height is very large, hiding notifications. That's why I haven't really looked into this...

One solution would be to always have it set to the outputs height while only allowing input inside the used area (setting the surfaces input region). Not sure if this is possible in GTK though

@modestbadger1773
Copy link
Author

I mean, the same is true for notification-widow-width.

I think both should be available to the user with comments next to them to warn of their misuse.

screenrecord.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants