Fix default mpris icon size #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The widget was was using the .ui size instead of the user config size in the following situations: - there was no media player app - the media player app icon was used - the audio-x-generic-symbolic icon was used This fix sets the default size for the album art icon according to the user's config. set_from_gicon and set_from_icon_name receive a Gtk.IconSize enum value, not an int, so we need to call set_pixel_size to set the proper size.
abmantis
force-pushed
the
fix_mpris_icon_size_all
branch
from
146acec
to
a21d46f
Compare
ErikReider
requested changes
Feb 10, 2024
| @@ -380,11 +381,11 @@ namespace SwayNotificationCenter.Widgets.Mpris { | |||
| icon = desktop_entry.get_icon (); | |||
| } | |||
| if (icon != null) { | |||
| album_art.set_from_gicon (icon, mpris_config.image_size); | |||
| album_art.set_from_gicon (icon, Gtk.IconSize.DIALOG); | |||
There was a problem hiding this comment.
These should be Gtk.IconSize.INVALID
|
Could you also update the branch off of main? |
…nto fix_mpris_icon_size_all
ErikReider
approved these changes
Mar 8, 2024
ErikReider
requested changes
Mar 8, 2024
| @@ -96,6 +96,7 @@ namespace SwayNotificationCenter.Widgets.Mpris { | |||
| update_buttons (source.media_player.metadata); | |||
| }); | |||
| }); | |||
| album_art.set_pixel_size(mpris_config.image_size); | |||
There was a problem hiding this comment.
Oh wait, seems like the linter isn't happy about this line. Could you fix that?
There was a problem hiding this comment.
Done. There are a lot of linter changes showing up, so I missed this one (I did not want to add unrelated line changes n this PR).
Maybe it would be nice to lint the whole project and do a single commit with that.
This was referenced Mar 8, 2024
ErikReider
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The widget was was using the .ui size instead of the user config
size in the following situations:
This fix sets the default size for the album art icon according to the
user's config.
set_from_gicon and set_from_icon_name receive a Gtk.IconSize enum value,
not an int, so we need to call set_pixel_size to set the proper size.