Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty name for actions #272

Merged
merged 2 commits into from
May 30, 2023
Merged

Allow empty name for actions #272

merged 2 commits into from
May 30, 2023

Conversation

slikie
Copy link
Contributor

@slikie slikie commented May 30, 2023

fix #269

with this inline reply and click to jump to dialog works perfectly

ErikReider
ErikReider requested changes May 30, 2023
View reviewed changes
Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits

src/notiModel/notiModel.vala Outdated Show resolved Hide resolved
src/notiModel/notiModel.vala Outdated Show resolved Hide resolved
@slikie
Copy link
Contributor Author

slikie commented May 30, 2023

fixed

ErikReider
ErikReider approved these changes May 30, 2023
View reviewed changes
Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@ErikReider ErikReider merged commit d46833b into ErikReider:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikReider ErikReider ErikReider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] nheko actions didnt get pick up
2 participants
@slikie @ErikReider