-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per app volume control #235
Conversation
I'll try to get to this tonight. If not, ping me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Finally had some free time after "finishing" blur work in SwayFX :)
No worries 😄 I'm aware of the issue with deleting elements. The reason is that I close the client when the cc is closed. And since the To solve this I could either never close the client or always update the active sinks when opening the cc... But solutions seem sub-optimal to me. I'll see if I can find a better way :) |
If there's no other way, this would be the more optimal solution :) |
Finally found the time to look into it again :) Should work now 😄 |
Fixed the issues and added a label to be displayed when the list of active sink inputs is empty :) Should be ready now 😄 |
Probably just a line ending issue |
3f0b666
to
5570011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again for all of the help :)
Haven't tested everything yet, but apart from that should be ready :)