-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio slider #207
Audio slider #207
Conversation
Hmm... Maybe I'll just move the installation of the needed packages into the respective action. Seems easier than hosting a docker image that I usually forget to update |
True, might be easier.. But here is a way to do it via an action GitHub Docker action.. I could look into it a bit more next weekend if you'd like. |
Wouldn't the main image be updated then? Or can you create different sub-tags and delete them on merge? |
Hmm true.. you could build/use the images locally in the action when on sub-branches and only push to docker-hub when on main. But I think that would still be a bad idea since that would mean you'd push the images everytime you push to main. Even if there were no changes to the dockerfiles (which I assume is the case 90% of the time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to remove the dockerfiles in main to fix the build issues. Other than that, the requested changes, and if everything builds correctly, I'll merge :)
63a8cb4
to
793c490
Compare
Fixed the issues and added the additional dependencies to the build files, should hopefully work now :) |
793c490
to
3c3724d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Got the next PR already prepared :) It should be a bit more straight forward since it's pretty much just your code from SwaySettings with some stuff removed ;)