Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio slider #207

Merged
merged 7 commits into from
Feb 12, 2023
Merged

Audio slider #207

merged 7 commits into from
Feb 12, 2023

Conversation

JannisPetschenka
Copy link
Contributor

Got the next PR already prepared :) It should be a bit more straight forward since it's pretty much just your code from SwaySettings with some stuff removed ;)

@ErikReider
Copy link
Owner

Hmm... Maybe I'll just move the installation of the needed packages into the respective action. Seems easier than hosting a docker image that I usually forget to update

@JannisPetschenka
Copy link
Contributor Author

Hmm... Maybe I'll just move the installation of the needed packages into the respective action. Seems easier than hosting a docker image that I usually forget to update

True, might be easier.. But here is a way to do it via an action GitHub Docker action.. I could look into it a bit more next weekend if you'd like.

@ErikReider
Copy link
Owner

True, might be easier.. But here is a way to do it via an action GitHub Docker action.. I could look into it a bit more next weekend if you'd like.

Wouldn't the main image be updated then? Or can you create different sub-tags and delete them on merge?

@JannisPetschenka
Copy link
Contributor Author

Wouldn't the main image be updated then? Or can you create different sub-tags and delete them on merge?

Hmm true.. you could build/use the images locally in the action when on sub-branches and only push to docker-hub when on main. But I think that would still be a bad idea since that would mean you'd push the images everytime you push to main. Even if there were no changes to the dockerfiles (which I assume is the case 90% of the time).
So manually might be the way to go :)

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to remove the dockerfiles in main to fix the build issues. Other than that, the requested changes, and if everything builds correctly, I'll merge :)

src/controlCenter/widgets/volume/volume.vala Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/controlCenter/widgets/volume/volume.vala Show resolved Hide resolved
src/controlCenter/widgets/volume/volume.vala Outdated Show resolved Hide resolved
src/controlCenter/widgets/volume/volume.vala Outdated Show resolved Hide resolved
@JannisPetschenka
Copy link
Contributor Author

Fixed the issues and added the additional dependencies to the build files, should hopefully work now :)

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ErikReider ErikReider merged commit bfcf9b9 into ErikReider:main Feb 12, 2023
@JannisPetschenka JannisPetschenka deleted the AudioSlider branch November 12, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants