Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client flags to turn dnd on/off #169

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

bvergnaud
Copy link
Contributor

Hello 👋🏻

This is a QoL PR I offer, for which I'll be the first client. Unless I missed something, setting dnd state to on or off currently requires getting the current dnd state, and toggling if necessary. With this MR, it'll be doable in a single call to the client. Less bash scripts everywhere can only be a good thing for the world. 😛

Fair warning:

  • This is my first time poking in this codebase. I might have missed things. Feel free to tell me if anything needs tweaking.
  • Up until today, I'd never even heard of vala. The edit is small and simple, and the code seems pretty straightforward, but reviewers should assume it's been written by a newbie, I won't take it personally. 😄

Thanks !

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it looks good to me! :)

completions/zsh/_swaync-client Outdated Show resolved Hide resolved
src/client.vala Outdated Show resolved Hide resolved
Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the help! :)

@ErikReider ErikReider merged commit 81fb57e into ErikReider:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants