Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version in test to 3.12 #858

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix python version in test to 3.12 #858

merged 2 commits into from
Jan 30, 2025

Conversation

tommystendahl
Copy link
Collaborator

The latest version (3.29.2) of the python driver does not support python 3.13, once a new version of the python-driver supporting python 3.13 is available this change should be reverted.

The latest version (3.29.2) of the python driver does not support python 3.13, once a new version of the python-driver supporting python 3.13 is available this change should be reverted.
@tommystendahl tommystendahl requested a review from a team as a code owner January 29, 2025 12:33
@tommystendahl tommystendahl requested a review from jwaeab January 29, 2025 12:33
@tommystendahl tommystendahl self-assigned this Jan 29, 2025
@@ -92,7 +92,7 @@ jobs:
- name: Set up Python 3
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: 3
python-version: 3.12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just adding some sort of comment here to why we explicitly set 3.12 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tommystendahl tommystendahl requested a review from jwaeab January 29, 2025 12:44
@tommystendahl tommystendahl merged commit 736e361 into master Jan 30, 2025
28 checks passed
@tommystendahl tommystendahl deleted the fix_python branch January 30, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants