Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace os.uname() with platform.uname() for Windows support #4012

Merged
merged 1 commit into from
Sep 25, 2023
Merged

replace os.uname() with platform.uname() for Windows support #4012

merged 1 commit into from
Sep 25, 2023

Conversation

petermbauer
Copy link
Contributor

fix for #3968

@whisperity whisperity added bugfix 🔨 analyzer 📈 Related to the analyze commands (analysis driver) platform-Windows 🖥 labels Sep 21, 2023
whisperity
whisperity approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch works all the way back to Ubuntu 14.04 at least (I did not go further back 😏), so I believe this should be safe to merge.

@bruntib bruntib merged commit 554a376 into Ericsson:master Sep 25, 2023
@bruntib bruntib mentioned this pull request Sep 25, 2023
Closed
@whisperity whisperity mentioned this pull request Sep 26, 2023
Open
@whisperity whisperity added this to the release 6.23.0 milestone Oct 18, 2023
@bruntib bruntib mentioned this pull request Oct 30, 2023
Closed
@petermbauer petermbauer deleted the fix-analyze-windows branch November 7, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@whisperity whisperity whisperity approved these changes

@vodorok vodorok Awaiting requested review from vodorok vodorok is a code owner

Assignees
No one assigned
Labels
analyzer 📈 Related to the analyze commands (analysis driver) bugfix 🔨 platform-Windows 🖥
Projects
None yet
Milestone
release 6.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@petermbauer @whisperity @bruntib