Fix chained negation generating prefix decrement operators incorrectly #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
changed the title
ErichDonGubler
force-pushed
the
fix-chained-negation
branch
from
c4b46a2
to
55a5928
Compare
ErichDonGubler
changed the title
* Fix incorrect atomic bounds check on metal back-end Generalize put_atomic_fetch to handle `exchange` as well, rather than special-cased code which didn't do the bounds check (the check handling as fixed in gfx-rs#1703 but only for the fetch cases, exchange was skipped). Fixes gfx-rs#1848 * Add tests for atomic exchange
* build: move to the Rust 2021 edition Since the MSRV of `naga` [is currently 1.56][msrv], I don't think there's a strong reason to stay with the 2018 edition, and there _are_ a [few good reasons][edition-guide] to move to the 2021 edition. I did this migration mostly automatically, per [official Rust guidelines]: ```sh $ cargo fix --edition --all-targets $ sed -i Cargo.toml 's/2018/2021' $ cargo fix --edition-idioms --allow-dirty # doesn't change anything ``` The only manual edit needed to stymie a new warning introduced was the removal of the `TryFrom` import in several modules, since it's now in the 2021 prelude. [msrv]: https://github.com/gfx-rs/naga/blob/a7193d652e49180661a6ca047889e0685667acdb/.github/workflows/pipeline.yml#L14 [edition-guide]: https://doc.rust-lang.org/edition-guide/rust-2021/index.html [official Rust guidelines]: https://doc.rust-lang.org/cargo/commands/cargo-fix.html#edition-migration * refactor(wgsl-in): use `pat` instead of `pat_param` again How we were using `pat` in the Rust 2018 edition is actually the use case that Rust 2021's `pat` fragment specifier is intended to satisfy. So, let's just use that!
ErichDonGubler
force-pushed
the
fix-chained-negation
branch
from
55a5928
to
d59a720
Compare
* Fix textureGather compatibility on macOS 10.13 * Fix tests * Update src/back/msl/writer.rs Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com> Co-authored-by: Jet Spark <lixiaopeng.jetspark@bytedance.com> Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
ErichDonGubler
force-pushed
the
fix-chained-negation
branch
from
d59a720
to
ad0ef2b
Compare
ErichDonGubler
force-pushed
the
minus
branch
4 times, most recently
from
d8916df
to
bb212fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves gfx-rs#2088. Depends on gfx-rs#2087.
TODO: