Accommodate limitation

EricLBuehler · Oct 31, 2023 · 98592e6 · 98592e6
1 parent 7f0c225
commit 98592e6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/candle-lora-transformers/examples/llama.rs b/candle-lora-transformers/examples/llama.rs
@@ -114,12 +114,17 @@ fn main() -> Result<()> {
     };
 
     let device = candle_examples::device(args.cpu)?;
-    let dtype = match args.dtype.as_deref() {
-        Some("f16") => DType::F16,
-        Some("bf16") => DType::BF16,
-        Some("f32") => DType::F32,
-        Some(dtype) => bail!("Unsupported dtype {dtype}"),
-        None => DType::F16,
+    let dtype = if device.is_cpu() {
+        match args.dtype.as_deref() {
+            Some("f16") => DType::F16,
+            Some("bf16") => DType::BF16,
+            Some("f32") => DType::F32,
+            Some(dtype) => bail!("Unsupported dtype {dtype}"),
+            None => DType::F16,
+        }
+    } else {
+        //Limitation of `rand_normal`, see https://github.com/huggingface/candle/issues/1224
+        DType::F32
     };
 
     let (llama, tokenizer_filename, cache) = match args.npy {

diff --git a/candle-lora-transformers/examples/mistral.rs b/candle-lora-transformers/examples/mistral.rs
@@ -227,7 +227,7 @@ fn main() -> Result<()> {
 
     let device = candle_examples::device(args.cpu)?;
     let dtype = if device.is_cuda() {
-        DType::BF16
+        DType::F32 //DType::BF16 Limitation of `rand_normal`, see https://github.com/huggingface/candle/issues/1224
     } else {
         DType::F32
     };

diff --git a/candle-lora-transformers/examples/stable_lm.rs b/candle-lora-transformers/examples/stable_lm.rs
@@ -224,7 +224,7 @@ fn main() -> Result<()> {
 
     let device = candle_examples::device(args.cpu)?;
     let dtype = if device.is_cuda() {
-        DType::BF16
+        DType::F32 //DType::BF16 Limitation of `rand_normal`, see https://github.com/huggingface/candle/issues/1224
     } else {
         DType::F32
     };