modified StateofTexas to pull all datasets - Challenge 1 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nefsen402
requested changes
Feb 14, 2023
scrapers/StateOfTexas.mjs
Outdated
| ]); | ||
|
|
||
| // Parsing the response data from JSON to objects | ||
| const [collectionsData, resourcesData] = await Promise.all([collectionsResponse.json(), resourcesResponse.json()]); |
There was a problem hiding this comment.
I would prefer the fetch/json parsing to be is series instead of parallel.
scrapers/StateOfTexas.mjs
Outdated
| if (!collectionIds) { | ||
|
|
||
| // Fetching collection_id data from the API and mapping the results to an array | ||
| const idData = await (await fetch('https://api.tnris.org/api/v1/collections_catalog/')).json(); |
There was a problem hiding this comment.
Please reuse the baseUrl here.
scrapers/StateOfTexas.mjs
Outdated
| @@ -1,32 +1,53 @@ | |||
| import fetch from 'node-fetch'; | |||
| import moment from 'moment'; | |||
|
|
|||
| const baseUrl = 'https://api.tnris.org/api/v1'; | |||
| let collectionIds = null; | |||
There was a problem hiding this comment.
This cache isn't a great idea, it's over complex and is confusing. The scrapers aren't run constantly, only on a infrequent but still reasonable schedule.
scrapers/StateOfTexas.mjs
Outdated
| // Looping over each collection_id | ||
| for (const id of collectionIds) { | ||
| // Building the URLs for the collections and resources endpoints | ||
| var collections = `collections/${id}`; |
There was a problem hiding this comment.
Please use let/const over var.
scrapers/StateOfTexas.mjs
Outdated
| collectionIds = idData.results.map(function(item) { return item["collection_id"]; }); | ||
| } | ||
|
|
||
| const data=[]; |
There was a problem hiding this comment.
Please use proper whitespace around operators to be more consistent with the file, and the rest of the code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collectionandresource)