Updated StateOfTexas #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nefsen402
requested changes
Feb 14, 2023
|
|
||
| // Loop through each result | ||
| results.map(item => { |
There was a problem hiding this comment.
Although a problem with the original code, The usage of map is inappropriate here. Please use forEach instead.
| }); | ||
| }); | ||
| } | ||
| // Return the data array |
There was a problem hiding this comment.
These comments are unnecessary, they don't add any more insight to what is happening.
| // Convert the response to a JSON object | ||
| const catalogResult = await collectionsCatalogRequest.json(); | ||
| // Extract the collection ids from the result | ||
| let collection_ids = catalogResult['results']; |
There was a problem hiding this comment.
Please prefer to use obj.results over obj['results'].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a for loop to loop through the collection_ids obtained from the API call to the collections_catalog endpoint. For each id in collection_ids, I made two API calls, one to collections/{id} and one to resources?collection_id={id}. I then destructured the relevant information from the responses of both API calls, such as publication_date, description, and name.