Modification in StateTexas to pull all datasets #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nefsen402
requested changes
Feb 14, 2023
| @@ -27,6 +33,7 @@ export default ({ database, DataScraper }) => { | |||
| }); | |||
| }); | |||
|
|
|||
| } | |||
|
|
||
| for(let i = 0; i < Ids.length ; i++) /*The classic for loop does not requires a big polyfill*/ { |
There was a problem hiding this comment.
Polyfills aren't a concern here, it's being run on a controlled environment.
| const collection = await collectionsRequest.json(); | ||
| const resourcesRequest = await fetch(`${baseUrl}/${resources}`); | ||
| const resource = await resourcesRequest.json(); | ||
| const IdsRequest = await fetch(`${baseUrl}/collections_catalog/`); |
There was a problem hiding this comment.
We don't use pascal case, but camel case instead. Please be mindful about code styling used.
|
|
||
| const [collectionsRequest, resourcesRequest] = await Promise.all([fetch(`${baseUrl}/${collections}`), fetch(`${baseUrl}/${resources}`)]); | ||
|
|
||
| const [collection, resource] = await Promise.all([collectionsRequest.json(), resourcesRequest.json()]); |
There was a problem hiding this comment.
I would prefer to see the fetch/json parsing happen in series instead of parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was changed the State Texas to pull all datasets.
Now, first it fetchs all ids and the iterate over to pull all datasets.