Fix ConfigSpace dependency issue #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: *Type is an invalid name according to pylint. They recommend using the suffix T instead of Type: pylint-dev/pylint#6003 (comment)
lebrice
approved these changes
Jul 4, 2022
Why: In newest versions of numpy, passing a list for indices is not the same as `array[d1, d2, d3]`, but using a tuple works.
Why: New version of numpy (1.23) leads to slightly different values (something like 10th decimal) which makes tests fail. Instead of updating the hardcoded values in the tests, we should use directly numpy.log so that it is adjusted to numpy's version.
bouthilx
force-pushed
the
hotfix/config_space_dep
branch
from
4776696 to
e813ec2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.